Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Rename incidentdate to occurreddate in DB [TECH-1665] #15700

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

enricocolasante
Copy link
Contributor

@enricocolasante enricocolasante commented Nov 15, 2023

Following on #15687

This PR aims to replace all occurrences of incidentDate in the DB and repository layer to occurredDate.
The general rule that we are using is that date fields are suffixed with At in the API and then suffixed with Date in the service and the DB layer.

@enricocolasante enricocolasante added the run-api-analytics-tests Enables analytics e2e tests label Nov 15, 2023
Copy link

sonarcloud bot commented Nov 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
24.2% 24.2% Duplication

@enricocolasante enricocolasante marked this pull request as ready for review November 15, 2023 10:47
@enricocolasante enricocolasante requested review from gnespolino, muilpp, maikelarabori and a team and removed request for muilpp November 15, 2023 10:47
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Merging #15700 (ffbce21) into master (0adbc6a) will increase coverage by 0.00%.
Report is 2 commits behind head on master.
The diff coverage is 80.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #15700   +/-   ##
=========================================
  Coverage     66.21%   66.21%           
+ Complexity    31281    31276    -5     
=========================================
  Files          3483     3483           
  Lines        129910   129910           
  Branches      15181    15181           
=========================================
+ Hits          86021    86022    +1     
+ Misses        36808    36801    -7     
- Partials       7081     7087    +6     
Flag Coverage Δ
integration 49.92% <80.00%> (-0.01%) ⬇️
integration-h2 32.31% <35.00%> (+0.02%) ⬆️
unit 30.28% <15.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ics/table/JdbcEnrollmentAnalyticsTableManager.java 94.91% <100.00%> (ø)
...nalytics/table/JdbcEventAnalyticsTableManager.java 81.66% <100.00%> (ø)
...table/JdbcTeiEnrollmentsAnalyticsTableManager.java 88.23% <100.00%> (ø)
...rg/hisp/dhis/program/DefaultEnrollmentService.java 53.20% <100.00%> (ø)
...ava/org/hisp/dhis/program/DefaultEventService.java 27.17% <100.00%> (ø)
.../org/hisp/dhis/program/variable/vIncidentDate.java 100.00% <100.00%> (ø)
...ker/trackedentity/store/query/EnrollmentQuery.java 98.14% <100.00%> (ø)
...hisp/dhis/tracker/export/event/JdbcEventStore.java 85.43% <100.00%> (ø)
...ort/trackedentity/HibernateTrackedEntityStore.java 68.19% <100.00%> (ø)
...ggregates/mapper/EnrollmentRowCallbackHandler.java 97.77% <100.00%> (ø)
... and 3 more

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc33046...ffbce21. Read the comment docs.

@enricocolasante enricocolasante enabled auto-merge (squash) November 15, 2023 10:48
@enricocolasante enricocolasante merged commit a1af060 into master Nov 16, 2023
18 checks passed
@enricocolasante enricocolasante deleted the TECH-1665-DB branch November 16, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-api-analytics-tests Enables analytics e2e tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants