Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix local failing test #15714

Merged
merged 1 commit into from
Nov 16, 2023
Merged

fix: Fix local failing test #15714

merged 1 commit into from
Nov 16, 2023

Conversation

enricocolasante
Copy link
Contributor

Applying #12786 fixes in 2.39 branch

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #15714 (f33d767) into 2.39 (886690f) will increase coverage by 6.19%.
Report is 118 commits behind head on 2.39.
The diff coverage is 67.11%.

Additional details and impacted files
@@             Coverage Diff              @@
##               2.39   #15714      +/-   ##
============================================
+ Coverage     58.58%   64.77%   +6.19%     
- Complexity    25817    28694    +2877     
============================================
  Files          3207     3212       +5     
  Lines        121397   121821     +424     
  Branches      14158    14221      +63     
============================================
+ Hits          71118    78908    +7790     
+ Misses        44340    36428    -7912     
- Partials       5939     6485     +546     
Flag Coverage Δ
integration 48.57% <38.96%> (-0.02%) ⬇️
integration-h2 33.96% <18.58%> (?)
unit 29.54% <44.93%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...main/java/org/hisp/dhis/appmanager/AppManager.java 100.00% <ø> (ø)
...src/main/java/org/hisp/dhis/category/Category.java 65.21% <100.00%> (ø)
...ava/org/hisp/dhis/common/BaseAnalyticalObject.java 70.95% <100.00%> (+5.81%) ⬆️
...a/org/hisp/dhis/common/BaseIdentifiableObject.java 80.20% <100.00%> (+1.37%) ⬆️
...s-api/src/main/java/org/hisp/dhis/common/Grid.java 0.00% <ø> (ø)
.../src/main/java/org/hisp/dhis/common/QueryItem.java 68.66% <100.00%> (ø)
...isp/dhis/dataapproval/DataApprovalPermissions.java 91.66% <ø> (+22.43%) ⬆️
...rc/main/java/org/hisp/dhis/feedback/ErrorCode.java 100.00% <100.00%> (ø)
...src/main/java/org/hisp/dhis/period/PeriodType.java 85.45% <100.00%> (+1.91%) ⬆️
...rg/hisp/dhis/resourcetable/ResourceTableStore.java 100.00% <ø> (+100.00%) ⬆️
... and 115 more

... and 545 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a55cc6...f33d767. Read the comment docs.

@enricocolasante enricocolasante marked this pull request as ready for review November 16, 2023 10:18
@enricocolasante enricocolasante requested review from jason-p-pickering and a team November 16, 2023 10:18
@enricocolasante enricocolasante enabled auto-merge (squash) November 16, 2023 10:18
@enricocolasante enricocolasante merged commit 0cf9d65 into 2.39 Nov 16, 2023
@enricocolasante enricocolasante deleted the fix_local_test_2.39 branch November 16, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants