Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch/2.39.3.1 15645 15661 #15721

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Patch/2.39.3.1 15645 15661 #15721

merged 2 commits into from
Nov 16, 2023

Conversation

jason-p-pickering
Copy link
Contributor

@jason-p-pickering jason-p-pickering commented Nov 16, 2023 •
edited by jira bot
Loading

Backport of two commits related to DataValueSet import stability and performance: DHIS2-15362

jbee and others added 2 commits November 16, 2023 11:50
@jbee @jason-p-pickering
fix: always flush the batch handler for CompleteDataSet import [DHIS2…
f8e87a1 
…-15362] (2.39) (#15625)

* fix: always flush the batch handler for CompleteDataSet import [DHIS2-15362]

* fix: test setup

* fix: controller imports use interface not impl
@jason-p-pickering
Use try-with-resources to close BatchHandler (#15661) (#15704)
f0fe950 
* Use try-with-resources to close BatchHandler

* Rework test to deal with multi-threading

* Add try-catch to Analytics table manager
Philip-Larsen-Donnelly
Philip-Larsen-Donnelly approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@Philip-Larsen-Donnelly Philip-Larsen-Donnelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved as backport

@jason-p-pickering jason-p-pickering merged commit 036b329 into patch/2.39.3.1 Nov 16, 2023
9 checks passed
@jason-p-pickering jason-p-pickering deleted the patch/2.39.3.1-15645-15661 branch November 16, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Philip-Larsen-Donnelly Philip-Larsen-Donnelly Philip-Larsen-Donnelly approved these changes

@jbee jbee Awaiting requested review from jbee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jason-p-pickering @Philip-Larsen-Donnelly @jbee