fix: getScheduledNotifications() should take in DataSetNotificationTrigger #15752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbee
approved these changes
Nov 22, 2023
.../dhis-api/src/main/java/org/hisp/dhis/dataset/notifications/DataSetNotificationTemplate.java
Outdated
Show resolved
Hide resolved
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #15752 +/- ##
=========================================
Coverage 66.29% 66.29%
Complexity 31373 31373
=========================================
Files 3482 3482
Lines 129965 129965
Branches 15200 15200
=========================================
+ Hits 86160 86162 +2
+ Misses 36713 36709 -4
- Partials 7092 7094 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
vietnguyen
force-pushed
the
add-DataSetNotificationTemplateStoreTest
branch
from
4ae3486 to
7172e3b
Compare
vietnguyen
force-pushed
the
add-DataSetNotificationTemplateStoreTest
branch
from
7172e3b to
7662fb4
Compare
|
Kudos, SonarCloud Quality Gate passed! |
david-mackessy
approved these changes
Nov 22, 2023
vietnguyen
added a commit
that referenced
this pull request
Nov 23, 2023
vietnguyen
added a commit
that referenced
this pull request
Nov 23, 2023
vietnguyen
added a commit
that referenced
this pull request
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
HibernateDataSetNotificationTemplateStore.getScheduledNotificationstakes in parameterorg.hisp.dhis.program.notification.NotificationTriggerwhich is incorrect and cause errorFix
HibernateDataSetNotificationTemplateStore.getScheduledNotificationsshould take inorg.hisp.dhis.dataset.notifications.DataSetNotificationTriggerDataSetNotificationTemplateStoreTest