Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix default values for pagination in tracker exporters #15779

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

enricocolasante
Copy link
Contributor

PR #15724 broke the default for pagination in tracker exporters

@enricocolasante enricocolasante requested review from muilpp and a team November 27, 2023 15:17
@enricocolasante enricocolasante enabled auto-merge (squash) November 27, 2023 15:17
Copy link

sonarcloud bot commented Nov 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Merging #15779 (46f2cc0) into master (abcd608) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #15779      +/-   ##
============================================
+ Coverage     66.24%   66.29%   +0.04%     
- Complexity    31414    31425      +11     
============================================
  Files          3492     3492              
  Lines        130216   130216              
  Branches      15217    15217              
============================================
+ Hits          86266    86321      +55     
+ Misses        36857    36802      -55     
  Partials       7093     7093              
Flag Coverage Δ
integration 50.01% <0.00%> (+0.01%) ⬆️
integration-h2 32.35% <0.00%> (+0.05%) ⬆️
unit 30.31% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...i/controller/tracker/export/PageRequestParams.java 100.00% <100.00%> (+50.00%) ⬆️
...troller/tracker/export/RequestParamsValidator.java 95.59% <100.00%> (ø)

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abcd608...46f2cc0. Read the comment docs.

@enricocolasante enricocolasante merged commit fa1a8aa into master Nov 27, 2023
17 checks passed
@enricocolasante enricocolasante deleted the fix_pagination branch November 27, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants