Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean: Remove dead code [ TECH-1618 ] #15784

Merged
merged 1 commit into from
Nov 29, 2023
Merged

clean: Remove dead code [ TECH-1618 ] #15784

merged 1 commit into from
Nov 29, 2023

Conversation

lucaCambi77
Copy link
Contributor

@lucaCambi77 lucaCambi77 commented Nov 28, 2023

https://dhis2.atlassian.net/browse/TECH-1618

There isn't much dead code left in the tracker to clean up actually.
With this PR, we do some quick cleanup based on IntelliJ code inspection

Copy link

sonarcloud bot commented Nov 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Merging #15784 (423a0e7) into master (e434a0b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #15784   +/-   ##
=========================================
  Coverage     66.28%   66.28%           
- Complexity    31415    31416    +1     
=========================================
  Files          3492     3492           
  Lines        130200   130199    -1     
  Branches      15211    15211           
=========================================
+ Hits          86306    86307    +1     
+ Misses        36801    36800    -1     
+ Partials       7093     7092    -1     
Flag Coverage Δ
integration 50.01% <100.00%> (+<0.01%) ⬆️
integration-h2 32.35% <66.66%> (+<0.01%) ⬆️
unit 30.31% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...er/export/enrollment/DefaultEnrollmentService.java 64.66% <ø> (ø)
...r/export/enrollment/EnrollmentOperationParams.java 75.00% <ø> (ø)
...his/tracker/export/event/EventOperationParams.java 80.00% <ø> (ø)
...port/relationship/RelationshipOperationParams.java 66.66% <ø> (ø)
...rt/trackedentity/TrackedEntityOperationParams.java 80.00% <ø> (ø)
...rackedentity/aggregates/mapper/AbstractMapper.java 100.00% <ø> (ø)
.../dhis/tracker/imports/TrackerBundleReportMode.java 100.00% <100.00%> (ø)
...p/dhis/tracker/imports/preheat/TrackerPreheat.java 89.08% <100.00%> (ø)
...sp/dhis/tracker/imports/programrule/IssueType.java 100.00% <100.00%> (ø)
.../imports/validation/validator/ValidationUtils.java 91.54% <ø> (-0.12%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e434a0b...423a0e7. Read the comment docs.

@lucaCambi77 lucaCambi77 requested a review from a team November 28, 2023 14:42
@lucaCambi77 lucaCambi77 merged commit 27eb779 into master Nov 29, 2023
18 checks passed
@lucaCambi77 lucaCambi77 deleted the TECH-1618 branch November 29, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants