Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore:Replace organisation units with no groups integrity check with SQL #15801

Merged
merged 9 commits into from
Nov 30, 2023

Conversation

jason-p-pickering
Copy link
Contributor

Replaces the integrity check relating to organisation units with no groups with an SQL based equivalent.

@jason-p-pickering jason-p-pickering requested review from jbee and a team November 30, 2023 10:21
Copy link
Contributor

@david-mackessy david-mackessy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, and covered with tests, even better 👍

Copy link

sonarcloud bot commented Nov 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Merging #15801 (801e095) into master (20bb935) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #15801   +/-   ##
=========================================
  Coverage     66.34%   66.34%           
- Complexity    31430    31432    +2     
=========================================
  Files          3489     3489           
  Lines        130091   130093    +2     
  Branches      15191    15191           
=========================================
+ Hits          86313    86316    +3     
  Misses        36700    36700           
+ Partials       7078     7077    -1     
Flag Coverage Δ
integration 50.04% <100.00%> (ø)
integration-h2 32.33% <0.00%> (-0.01%) ⬇️
unit 30.39% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...isp/dhis/dataintegrity/DataIntegrityCheckType.java 100.00% <ø> (ø)
...is/dataintegrity/FlattenedDataIntegrityReport.java 97.27% <100.00%> (+0.07%) ⬆️
...his/dataintegrity/DefaultDataIntegrityService.java 76.68% <100.00%> (-0.07%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20bb935...801e095. Read the comment docs.

@jason-p-pickering jason-p-pickering merged commit aade1cd into master Nov 30, 2023
18 checks passed
@jason-p-pickering jason-p-pickering deleted the DHIS2-16225 branch November 30, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants