chore: add Redirect from old icon endpoint [DHIS2-16042] #15802
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #15802 +/- ##
=============================================
+ Coverage 49.50% 66.34% +16.84%
- Complexity 23386 31441 +8055
=============================================
Files 3491 3491
Lines 130105 130106 +1
Branches 15192 15192
=============================================
+ Hits 64403 86322 +21919
+ Misses 59637 36705 -22932
- Partials 6065 7079 +1014
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1230 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| HttpServletResponse response, HttpServletRequest request, @PathVariable String iconKey) | ||
| throws IOException { | ||
| String location = response.encodeRedirectURL("/" + iconKey + "/icon"); | ||
| response.sendRedirect(ContextUtils.getRootPath(request) + location); |
Check warning
Code scanning / CodeQL
URL redirection from remote source Medium
| public void getIconData(HttpServletResponse response, @PathVariable String iconKey) | ||
| throws IOException, NotFoundException { | ||
| downloadDefaultIcon(iconKey, response); | ||
| public void getIconData( |
There was a problem hiding this comment.
should we also mark the endpoint as deprecated? or is it not necessary?
|
Kudos, SonarCloud Quality Gate passed! |
DHIS2-16042