Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Validate sort direction and remove unsupported options [TECH-1622] #15803

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

enricocolasante
Copy link
Contributor

@enricocolasante enricocolasante commented Nov 30, 2023

  • Validate SortDirection in order string. Any value different from ASC or DESC will generate a 400 response
  • Remove IASC and IDESC values from SortDirection enum as they were not supported

@enricocolasante enricocolasante changed the title chore: Validate sort direction and remove unsupported options [TECH-1… chore: Validate sort direction and remove unsupported options [TECH-1622] Nov 30, 2023
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Merging #15803 (f90e199) into master (20bb935) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #15803   +/-   ##
=========================================
  Coverage     66.34%   66.35%           
- Complexity    31430    31433    +3     
=========================================
  Files          3489     3489           
  Lines        130091   130090    -1     
  Branches      15191    15191           
=========================================
+ Hits          86313    86316    +3     
+ Misses        36700    36697    -3     
+ Partials       7078     7077    -1     
Flag Coverage Δ
integration 50.04% <70.00%> (-0.01%) ⬇️
integration-h2 32.33% <40.00%> (-0.01%) ⬇️
unit 30.40% <90.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../webapi/controller/event/mapper/SortDirection.java 100.00% <100.00%> (+8.33%) ⬆️
...api/controller/event/webrequest/OrderCriteria.java 93.33% <100.00%> (ø)
...p/dhis/webapi/common/OrderCriteriaParamEditor.java 100.00% <100.00%> (ø)
...p/dhis/webapi/controller/CrudControllerAdvice.java 70.12% <100.00%> (+0.19%) ⬆️
...hisp/dhis/webapi/security/config/WebMvcConfig.java 58.02% <ø> (+0.70%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20bb935...f90e199. Read the comment docs.

@enricocolasante enricocolasante added the run-api-analytics-tests Enables analytics e2e tests label Nov 30, 2023
Copy link

sonarcloud bot commented Nov 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@enricocolasante enricocolasante marked this pull request as ready for review November 30, 2023 13:58
@enricocolasante enricocolasante requested review from a team November 30, 2023 13:59
@enricocolasante enricocolasante enabled auto-merge (squash) November 30, 2023 13:59
@enricocolasante enricocolasante merged commit be4fe29 into master Nov 30, 2023
18 checks passed
@enricocolasante enricocolasante deleted the TECH-1622 branch November 30, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-api-analytics-tests Enables analytics e2e tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants