Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Replace data element no groups Java check with SQL based check #15812

Merged
merged 2 commits into from
Dec 4, 2023

Conversation

jason-p-pickering
Copy link
Contributor

  • Replaces check for aggregate data elements with no groups with a Java based check
  • Add unit test in legacy report

Copy link

sonarcloud bot commented Dec 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Merging #15812 (d4b5201) into master (d0e12c6) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #15812      +/-   ##
============================================
- Coverage     66.34%   66.34%   -0.01%     
  Complexity    31440    31440              
============================================
  Files          3491     3491              
  Lines        130107   130105       -2     
  Branches      15192    15192              
============================================
- Hits          86322    86320       -2     
- Misses        36704    36705       +1     
+ Partials       7081     7080       -1     
Flag Coverage Δ
integration 50.04% <100.00%> (+<0.01%) ⬆️
integration-h2 32.33% <0.00%> (-0.01%) ⬇️
unit 30.40% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...isp/dhis/dataintegrity/DataIntegrityCheckType.java 100.00% <ø> (ø)
...is/dataintegrity/FlattenedDataIntegrityReport.java 97.26% <100.00%> (-0.02%) ⬇️
...his/dataintegrity/DefaultDataIntegrityService.java 76.68% <100.00%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0e12c6...d4b5201. Read the comment docs.

Copy link
Contributor

@david-mackessy david-mackessy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice find, the sql type check was always there but never used?

@jason-p-pickering jason-p-pickering merged commit ac87838 into master Dec 4, 2023
18 checks passed
@jason-p-pickering jason-p-pickering deleted the DHIS2-16233 branch December 4, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants