Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only restrict set of checks when executing them [DHIS2-16256] (2.39) #15849

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

jbee
Copy link
Contributor

@jbee jbee commented Dec 6, 2023

cherry-picked from #15840

…his2#15840)

* fix: only restrict set of checks when executing them [DHIS2-16256]

* test: show that slow tests are included in summary [DHIS2-16256]
@jbee jbee self-assigned this Dec 6, 2023
@jbee jbee enabled auto-merge (squash) December 6, 2023 12:33
Copy link

sonarcloud bot commented Dec 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Merging #15849 (00f50c8) into 2.39 (886690f) will increase coverage by 6.28%.
Report is 125 commits behind head on 2.39.
The diff coverage is 70.25%.

Additional details and impacted files
@@             Coverage Diff              @@
##               2.39   #15849      +/-   ##
============================================
+ Coverage     58.58%   64.86%   +6.28%     
- Complexity    25817    28768    +2951     
============================================
  Files          3207     3215       +8     
  Lines        121397   121982     +585     
  Branches      14158    14233      +75     
============================================
+ Hits          71118    79129    +8011     
+ Misses        44340    36341    -7999     
- Partials       5939     6512     +573     
Flag Coverage Δ
integration 49.17% <46.95%> (+0.58%) ⬆️
integration-h2 34.06% <32.56%> (?)
unit 29.65% <43.07%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...main/java/org/hisp/dhis/appmanager/AppManager.java 100.00% <ø> (ø)
...src/main/java/org/hisp/dhis/category/Category.java 65.21% <100.00%> (ø)
...ava/org/hisp/dhis/common/BaseAnalyticalObject.java 70.95% <100.00%> (+5.81%) ⬆️
...a/org/hisp/dhis/common/BaseIdentifiableObject.java 80.20% <100.00%> (+1.37%) ⬆️
...s-api/src/main/java/org/hisp/dhis/common/Grid.java 0.00% <ø> (ø)
.../src/main/java/org/hisp/dhis/common/QueryItem.java 68.66% <100.00%> (ø)
...isp/dhis/dataapproval/DataApprovalPermissions.java 91.66% <ø> (+22.43%) ⬆️
...rg/hisp/dhis/dataintegrity/DataIntegrityCheck.java 100.00% <100.00%> (ø)
...isp/dhis/dataintegrity/DataIntegrityCheckType.java 100.00% <100.00%> (+100.00%) ⬆️
.../hisp/dhis/dataintegrity/DataIntegrityDetails.java 81.81% <ø> (+9.09%) ⬆️
... and 105 more

... and 575 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29f45b4...00f50c8. Read the comment docs.

@jbee jbee merged commit dff245b into dhis2:2.39 Dec 6, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants