fix: Missing support for headers + NPE/clean-up [DHIS2-16065] #15865

maikelarabori · 2023-12-08T10:38:54Z

This PR adds support for "headers" param, fixes a NPE and also fixes an exception handling that was not working correctly.

I noticed that exactly the same items and columns were used across many places. I grouped them into an Enum.

…_2.41

codecov · 2023-12-08T10:56:07Z

Codecov Report

Merging #15865 (326299c) into master (db8a664) will increase coverage by 0.01%.
Report is 3 commits behind head on master.
The diff coverage is 70.37%.

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #15865      +/-   ##
============================================
+ Coverage     66.37%   66.38%   +0.01%     
- Complexity    31435    31441       +6     
============================================
  Files          3487     3489       +2     
  Lines        130030   130128      +98     
  Branches      15183    15186       +3     
============================================
+ Hits          86307    86390      +83     
- Misses        36646    36663      +17     
+ Partials       7077     7075       -2

Flag	Coverage Δ
integration	`50.08% <68.25%> (+0.02%)`	⬆️
integration-h2	`32.36% <39.15%> (+0.02%)`	⬆️
unit	`30.44% <48.14%> (+0.02%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...src/main/java/org/hisp/dhis/period/PeriodType.java	`86.44% <ø> (ø)`
.../event/data/DefaultEnrollmentAnalyticsService.java	`80.00% <100.00%> (+5.00%)`	⬆️
...ytics/event/data/DefaultEventDataQueryService.java	`83.33% <100.00%> (+0.06%)`	⬆️
...nalytics/event/data/JdbcEventAnalyticsManager.java	`66.07% <100.00%> (+0.12%)`	⬆️
...his/analytics/table/JdbcAnalyticsTableManager.java	`68.58% <100.00%> (-0.55%)`	⬇️
...a/org/hisp/dhis/analytics/common/ColumnHeader.java	`100.00% <100.00%> (ø)`
...rdetection/parser/OutlierDetectionQueryParser.java	`85.71% <100.00%> (ø)`
...p/dhis/outlierdetection/OutlierDetectionQuery.java	`0.00% <0.00%> (ø)`
...rocessor/AnalyticsZScoreSqlStatementProcessor.java	`73.07% <75.00%> (ø)`
...ction/service/AbstractOutlierDetectionManager.java	`96.96% <75.00%> (ø)`
... and 5 more

... and 13 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0a14f9...326299c. Read the comment docs.