fix: make dataDimensionType mandatory for catOptionGroup and groupSet

[vietnguyen]

https://dhis2.atlassian.net/browse/DHIS2-14694

• DataDimensionType has not-null=true for Category and CategoryCombo but its nullable for CategoryOptionGroup and CategoryOptionGroupSet.

• In Maintenance app, the field DataDimensionType is disabled when editing. Therefore, if an object is created without DataDimensionType then it can't be updated with correct value.

• This PR add not-null=true for those classes in hbm mapping file.

Behavior change

• After this PR, the form field in maintenance app is marked as required.
• Metadata import will throw exception for missing required field.

Test

• Added unit tests and fixed various related integration tests

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[david-mackessy]

wondering if this could cause issues to entities that currently have null for this value in the DB? (or is that even possible)
If it is possible, imagine a GET is performed for an entity with a null dataDimensionType and then that entity is flushed and might throw an error.
Or is there a default dataDimensionType in play here somewhere?

[vietnguyen]

wondering if this could cause issues to entities that currently have null for this value in the DB? (or is that even possible)
If it is possible, imagine a GET is performed for an entity with a null dataDimensionType and then that entity is flushed and might throw an error.
Or is there a default dataDimensionType in play here somewhere?

@david-mackessy I thought about that. In this case I think we can't automatically update existing records because we can't be sure which is the correct value.
So i think it's better not to back-port this fix, then add a note to the breaking change section in upgrade notes for 2.41. User would need to manually correct their data before upgrade.
Beside, this feature is requested and only used by PEPFAR so I think the fix won't affect other implementations.