Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use try-with-resources in HibernateReservedValueStore #15886

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Use try-with-resources in HibernateReservedValueStore #15886

merged 2 commits into from
Dec 11, 2023

Conversation

jason-p-pickering
Copy link
Contributor

@jason-p-pickering jason-p-pickering commented Dec 11, 2023 •
edited
Loading

Now that the BatchHandler is Autocloseable, use it within a try-with-resources to ensure that there are no connection leaks.

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@jason-p-pickering jason-p-pickering merged commit 570c441 into master Dec 11, 2023
16 checks passed
@jason-p-pickering jason-p-pickering deleted the try-with-resources-reserved-values branch December 11, 2023 15:28
@jason-p-pickering jason-p-pickering restored the try-with-resources-reserved-values branch December 11, 2023 15:28
@jason-p-pickering jason-p-pickering deleted the try-with-resources-reserved-values branch December 11, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-mackessy david-mackessy david-mackessy approved these changes

@jbee jbee jbee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jason-p-pickering @jbee @david-mackessy