Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: json patch throw error when remove null property [DHIS2-16299] (39) #15923

Merged
merged 2 commits into from
Dec 13, 2023

Conversation

vietnguyen
Copy link
Contributor

@vietnguyen vietnguyen changed the title backport: fix: json patch throw error when remove null property fix: json patch throw error when remove null property [DHIS2-16299] (39) Dec 13, 2023
Copy link

sonarqubecloud bot commented Dec 13, 2023

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Merging #15923 (ee99128) into 2.39 (886690f) will increase coverage by 6.32%.
Report is 133 commits behind head on 2.39.
The diff coverage is 71.63%.

Additional details and impacted files
@@             Coverage Diff              @@
##               2.39   #15923      +/-   ##
============================================
+ Coverage     58.58%   64.90%   +6.32%     
- Complexity    25817    28794    +2977     
============================================
  Files          3207     3215       +8     
  Lines        121397   122019     +622     
  Branches      14158    14244      +86     
============================================
+ Hits          71118    79202    +8084     
+ Misses        44340    36293    -8047     
- Partials       5939     6524     +585     
Flag Coverage Δ
integration 49.19% <48.70%> (+0.60%) ⬆️
integration-h2 34.09% <33.18%> (?)
unit 29.64% <42.64%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...main/java/org/hisp/dhis/appmanager/AppManager.java 100.00% <ø> (ø)
...src/main/java/org/hisp/dhis/category/Category.java 65.21% <100.00%> (ø)
...ava/org/hisp/dhis/common/BaseAnalyticalObject.java 70.95% <100.00%> (+5.81%) ⬆️
...a/org/hisp/dhis/common/BaseIdentifiableObject.java 80.20% <100.00%> (+1.37%) ⬆️
...s-api/src/main/java/org/hisp/dhis/common/Grid.java 0.00% <ø> (ø)
.../src/main/java/org/hisp/dhis/common/QueryItem.java 68.66% <100.00%> (ø)
...isp/dhis/dataapproval/DataApprovalPermissions.java 91.66% <ø> (+22.43%) ⬆️
...rg/hisp/dhis/dataintegrity/DataIntegrityCheck.java 100.00% <100.00%> (ø)
...isp/dhis/dataintegrity/DataIntegrityCheckType.java 100.00% <100.00%> (+100.00%) ⬆️
.../hisp/dhis/dataintegrity/DataIntegrityDetails.java 81.81% <ø> (+9.09%) ⬆️
... and 103 more

... and 584 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bef33eb...ee99128. Read the comment docs.

@vietnguyen vietnguyen merged commit 9653394 into 2.39 Dec 13, 2023
11 checks passed
@vietnguyen vietnguyen deleted the DHIS2-16299-41_2.39 branch December 13, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants