Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task: Extract common validations to helper class [TECH-1677] #16013

Merged
merged 2 commits into from
Dec 21, 2023

Conversation

muilpp
Copy link
Contributor

@muilpp muilpp commented Dec 21, 2023

Move similar validations to helper class to reduce duplication in tracker exporters mappers.

Ticket: https://dhis2.atlassian.net/browse/TECH-1677

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (8b644f6) 66.39% compared to head (a991290) 66.39%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #16013      +/-   ##
============================================
- Coverage     66.39%   66.39%   -0.01%     
+ Complexity    31546    31521      -25     
============================================
  Files          3507     3507              
  Lines        130586   130533      -53     
  Branches      15242    15226      -16     
============================================
- Hits          86703    86663      -40     
+ Misses        36809    36804       -5     
+ Partials       7074     7066       -8     
Flag Coverage Δ
integration 50.32% <71.87%> (+<0.01%) ⬆️
integration-h2 32.37% <21.87%> (+0.01%) ⬆️
unit 30.34% <89.06%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...dhis/tracker/export/OperationsParamsValidator.java 89.23% <100.00%> (+22.56%) ⬆️
...er/export/enrollment/DefaultEnrollmentService.java 92.47% <ø> (ø)
...rt/enrollment/EnrollmentOperationParamsMapper.java 94.28% <100.00%> (+5.53%) ⬆️
...ckedentity/TrackedEntityOperationParamsMapper.java 76.11% <100.00%> (-0.53%) ⬇️
...acker/export/event/EventOperationParamsMapper.java 93.22% <90.90%> (-1.64%) ⬇️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8415ecd...a991290. Read the comment docs.

Copy link

sonarcloud bot commented Dec 21, 2023

@muilpp muilpp marked this pull request as ready for review December 21, 2023 12:57
@muilpp muilpp merged commit 9f2710d into master Dec 21, 2023
17 checks passed
@muilpp muilpp deleted the TECH-1677-exporter-mappers-validations branch December 21, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants