Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: programIndicators are now prefixed by programId in tei dimensions endpoint [DHIS2-16368] #16014

Merged
merged 3 commits into from
Dec 21, 2023

Conversation

gnespolino
Copy link
Contributor

No description provided.

Copy link

sonarcloud bot commented Dec 21, 2023

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (8b644f6) 66.39% compared to head (1773b0a) 66.39%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #16014      +/-   ##
============================================
- Coverage     66.39%   66.39%   -0.01%     
  Complexity    31546    31546              
============================================
  Files          3507     3507              
  Lines        130586   130587       +1     
  Branches      15242    15243       +1     
============================================
- Hits          86703    86702       -1     
- Misses        36809    36810       +1     
- Partials       7074     7075       +1     
Flag Coverage Δ
integration 50.32% <0.00%> (-0.01%) ⬇️
integration-h2 32.35% <0.00%> (-0.01%) ⬇️
unit 30.37% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...s/webapi/dimension/TeiAnalyticsPrefixStrategy.java 66.66% <50.00%> (-13.34%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8415ecd...1773b0a. Read the comment docs.

@gnespolino gnespolino merged commit 8edfccd into master Dec 21, 2023
17 checks passed
@gnespolino gnespolino deleted the DHIS2-16368_programPrefix-4-programIndicators branch December 21, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants