Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add more than one gateway for same type[DHIS2-13001] #16033

Merged
merged 5 commits into from
Jan 3, 2024
Merged

Conversation

zubaira
Copy link
Contributor

@zubaira zubaira commented Dec 27, 2023

Copy link

codecov bot commented Dec 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cfc3aad) 66.36% compared to head (a1256e5) 66.37%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #16033   +/-   ##
=========================================
  Coverage     66.36%   66.37%           
- Complexity    31519    31520    +1     
=========================================
  Files          3507     3507           
  Lines        130594   130583   -11     
  Branches      15238    15235    -3     
=========================================
- Hits          86673    86672    -1     
+ Misses        36848    36842    -6     
+ Partials       7073     7069    -4     
Flag Coverage Δ
integration 50.30% <ø> (+<0.01%) ⬆️
integration-h2 32.36% <ø> (+<0.01%) ⬆️
unit 30.34% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ms/config/DefaultGatewayAdministrationService.java 80.90% <ø> (-0.51%) ⬇️
...his/sms/config/DefaultSmsConfigurationManager.java 100.00% <ø> (+46.66%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfc3aad...a1256e5. Read the comment docs.

@zubaira zubaira marked this pull request as ready for review December 29, 2023 08:08
Copy link

sonarcloud bot commented Jan 3, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@zubaira zubaira merged commit 23f628c into master Jan 3, 2024
17 checks passed
@zubaira zubaira deleted the DHIS2-13001 branch January 3, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants