fix: condition to check eligible headers [DHIS2-16191] #16036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-bernat
approved these changes
Dec 28, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #16036 +/- ##
============================================
- Coverage 66.38% 66.37% -0.01%
+ Complexity 31526 31521 -5
============================================
Files 3507 3507
Lines 130575 130574 -1
Branches 15235 15234 -1
============================================
- Hits 86679 86673 -6
Misses 36828 36828
- Partials 7068 7073 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
maikelarabori
approved these changes
Dec 28, 2023
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a previous implementation on DHIS2-16191 we added a dedicated
parsedHeaderscollection to theTeiParamsobject, which represents a parsed version on theheadersquery parameter.This was done to support properly all kind of dimensions as headers.
However, some static headers were not added back properly in the final list of headers, for example as in the following query:
/analytics/trackedEntities/query/nEenWmSyUEp?headers=IpHINAT79UW.incidentdateThis PR aims is to fix this error