Fix: Fix the table population problem when the skip outliers switch is activated/deactivated #16037
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #16037 +/- ##
============================================
- Coverage 66.37% 66.37% -0.01%
- Complexity 31522 31524 +2
============================================
Files 3507 3507
Lines 130574 130594 +20
Branches 15234 15238 +4
============================================
+ Hits 86674 86678 +4
- Misses 36828 36847 +19
+ Partials 7072 7069 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Hi @d-bernat, the fix looks good. I added two comments that would be nice to address.
Cheers
| @@ -144,4 +156,11 @@ private OutlierRequest getFromQuery(OutlierQueryParams queryParams, boolean anal | |||
|
|
|||
| return request; | |||
| } | |||
|
|
|||
| private void checkAnalyticsTableForOutliers() { | |||
There was a problem hiding this comment.
This method should be moved to the class AnalyticsOutlierService, with a proper Javadoc.
| @@ -144,4 +156,11 @@ private OutlierRequest getFromQuery(OutlierQueryParams queryParams, boolean anal | |||
|
|
|||
| return request; | |||
| } | |||
|
|
|||
| private void checkAnalyticsTableForOutliers() { | |||
There was a problem hiding this comment.
Would be nice to have a e2e to test this error. Please see the class NoAnalyticsTablesErrorsScenariosTest. You can add a new test there to simulate this exception and assert the response/error.
There was a problem hiding this comment.
e2e is coming, there are no e2e for outliers at all now
There was a problem hiding this comment.
Okay, if you prefer to add it as part of all others e2e for Outliers is fine. Just please add a TODO in the class NoAnalyticsTablesErrorsScenariosTest, so we do not forget this scenario.
|
Hi @d-bernat, please do not forget to update the PR description with a proper one. Thanks. |
|
please see https://dhis2.atlassian.net/browse/DHIS2-16375