feat: Download is missing support for NAME, CODE, UID and ID #16049
Conversation
d-bernat
changed the title
d-bernat
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #16049 +/- ##
============================================
- Coverage 66.36% 66.36% -0.01%
- Complexity 31515 31519 +4
============================================
Files 3507 3507
Lines 130571 130572 +1
Branches 15235 15237 +2
============================================
Hits 86659 86659
- Misses 36840 36845 +5
+ Partials 7072 7068 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Hi @d-bernat, looks good. Just one minor comment related to the code. Please review it.
Also, please, add a description to the PR. Usually we describe at least what has changed and the motivation for it.
Cheers,
Maikel
| @@ -283,4 +303,18 @@ private void setRows(Grid grid, List<Outlier> outliers, OutlierRequest request) | |||
| grid.addValue(v.getUpperBound()); | |||
| }); | |||
| } | |||
|
|
|||
| private String getIdProperty(IdentifiableObject object, String uid, IdScheme idScheme) { | |||
|
Introduce support for the outputIdScheme parameter. Depending on the selected schema, all dimensions/headers should adhere to the specified scheme. The default scheme is 'UID.' The OutputIdScheme serves as an enumerator (with options such as ID, UID, UUID, CODE, NAME). Each identifiable object can be recognized by any of the listed values.
The request parameter outputIdScheme dictates the type of ID in the response. If outputIdScheme is not included in the incoming request, UID is applied by default. All IDs, except UID, are enhancements of the SQL result set (analytics table) performed using Hibernate ORM. Consequently, some columns (_name) from the analytics tables have become obsolete and were removed from both analytics exports and SQL select queries.