Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move SortDirection to common package TECH-1622 #16072

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Conversation

teleivo
Copy link
Contributor

@teleivo teleivo commented Jan 4, 2024

as its not tracker specific

as its not tracker specific
Copy link

sonarcloud bot commented Jan 4, 2024

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (142be5a) 66.36% compared to head (bbed4e6) 66.36%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #16072      +/-   ##
============================================
- Coverage     66.36%   66.36%   -0.01%     
+ Complexity    31518    31516       -2     
============================================
  Files          3507     3507              
  Lines        130572   130572              
  Branches      15237    15237              
============================================
- Hits          86656    86655       -1     
+ Misses        36847    36846       -1     
- Partials       7069     7071       +2     
Flag Coverage Δ
integration 50.30% <ø> (+<0.01%) ⬆️
integration-h2 32.36% <ø> (ø)
unit 30.33% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../main/java/org/hisp/dhis/common/SortDirection.java 100.00% <ø> (ø)
...api/controller/event/webrequest/OrderCriteria.java 93.33% <ø> (ø)
...nalytics/common/params/AnalyticsSortingParams.java 0.00% <ø> (ø)
...cs/common/processing/CommonQueryRequestMapper.java 86.36% <ø> (ø)
...va/org/hisp/dhis/analytics/common/query/Order.java 75.00% <ø> (ø)
...r/export/enrollment/EnrollmentOperationParams.java 75.00% <ø> (ø)
...acker/export/enrollment/EnrollmentQueryParams.java 52.38% <ø> (ø)
...his/tracker/export/event/EventOperationParams.java 80.00% <ø> (ø)
...sp/dhis/tracker/export/event/EventQueryParams.java 90.00% <ø> (ø)
...xport/relationship/HibernateRelationshipStore.java 90.00% <ø> (ø)
... and 4 more

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 142be5a...bbed4e6. Read the comment docs.

@teleivo teleivo enabled auto-merge (squash) January 4, 2024 10:17
@teleivo teleivo requested review from enricocolasante and a team January 4, 2024 10:17
@teleivo teleivo requested a review from a team January 4, 2024 10:38
@teleivo teleivo merged commit 167eb05 into master Jan 4, 2024
17 checks passed
@teleivo teleivo deleted the TECH-1622 branch January 4, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants