Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix warnings in tracker code #16079

Merged
merged 1 commit into from
Jan 5, 2024
Merged

chore: fix warnings in tracker code #16079

merged 1 commit into from
Jan 5, 2024

Conversation

teleivo
Copy link
Contributor

@teleivo teleivo commented Jan 4, 2024

  • use switch expressions. They simplify our code. They also need to be exhaustive, so in case we add a new value to an enum we will get a compilation error that we are missing a case
  • remove unused constants
  • remove private and final if these are already provided by lombok

* use switch expressions. They simplify our code. They also need to be
exhaustive, so in case we add a new value to an enum we will get a compilation
error that we are missing a case
* remove unused constants
* remove private and final if these are already provided by lombok
Copy link

sonarcloud bot commented Jan 4, 2024

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (64c54cf) 66.37% compared to head (a387510) 66.36%.
Report is 25 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #16079      +/-   ##
============================================
- Coverage     66.37%   66.36%   -0.01%     
+ Complexity    31523    31515       -8     
============================================
  Files          3507     3507              
  Lines        130594   130562      -32     
  Branches      15238    15237       -1     
============================================
- Hits          86676    86652      -24     
+ Misses        36848    36842       -6     
+ Partials       7070     7068       -2     
Flag Coverage Δ
integration 50.30% <51.16%> (+<0.01%) ⬆️
integration-h2 32.36% <13.95%> (-0.01%) ⬇️
unit 30.34% <74.41%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...cker/export/enrollment/EnrollmentEventsParams.java 100.00% <ø> (ø)
...isp/dhis/tracker/imports/TrackerIdSchemeParam.java 100.00% <100.00%> (+9.09%) ⬆️
...sp/dhis/tracker/imports/TrackerIdSchemeParams.java 100.00% <100.00%> (ø)
...isp/dhis/tracker/imports/bundle/TrackerBundle.java 72.97% <100.00%> (+4.55%) ⬆️
...his/tracker/imports/domain/MetadataIdentifier.java 91.89% <100.00%> (+5.04%) ⬆️
...p/dhis/tracker/imports/preheat/TrackerPreheat.java 90.17% <100.00%> (+1.09%) ⬆️
.../org/hisp/dhis/tracker/imports/report/Warning.java 100.00% <ø> (ø)
...tracker/imports/validation/PersistablesFilter.java 96.74% <100.00%> (ø)
...idation/validator/TrackerImporterAssertErrors.java 0.00% <ø> (ø)
...orts/validation/validator/event/DateValidator.java 90.69% <100.00%> (ø)
... and 2 more

... and 37 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f617b20...a387510. Read the comment docs.

@teleivo teleivo requested a review from a team January 5, 2024 08:04
@teleivo teleivo marked this pull request as ready for review January 5, 2024 08:04
@teleivo teleivo enabled auto-merge (squash) January 5, 2024 08:04
@teleivo teleivo merged commit f5377cc into master Jan 5, 2024
17 checks passed
@teleivo teleivo deleted the tracker-clean branch January 5, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants