fix: relationship used enrollment mapper for order DHIS2-15666 #16085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
these tests are in the export package and have nothing to do with import. Remove Import from their names. This allows IntelliJ to find their implementation again
enricocolasante
approved these changes
Jan 5, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #16085 +/- ##
=========================================
Coverage 66.39% 66.40%
- Complexity 31529 31533 +4
=========================================
Files 3507 3507
Lines 130575 130575
Branches 15242 15242
=========================================
+ Hits 86701 86712 +11
+ Misses 36791 36784 -7
+ Partials 7083 7079 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
We used the relationship mapper to validate any order field can be ordered by. We then accidentally used the enrollment mapper to map from view names to internal domain names. That worked in this case since relationships can only be ordered by createdAt/Client which is also supported by enrollment
teleivo
changed the title
|
enricocolasante
approved these changes
Jan 8, 2024
lucaCambi77
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix relationship used enrollment mapper for order
We used the relationship mapper to validate any order field can be ordered by. We then
accidentally used the enrollment mapper to map from view names to internal domain names.
That worked in this case since relationships can only be ordered by createdAt/Client
which is also supported by enrollment
fix test names. these tests are in the export package and have nothing to do with import. Remove Import from their names. This allows IntelliJ to find their implementation again.