Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: relative periods and pe dimension support #16087

Merged
merged 5 commits into from
Jan 8, 2024
Merged

Conversation

d-bernat
Copy link
Contributor

@d-bernat d-bernat commented Jan 6, 2024

For full support of the period dimension, the relative periods had to be included in the incoming request using the format of the query parameter pe=RELATIVE_PERIOD. Common relative period names, such as THIS_YEAR and LAST_12_MONTH, are accepted. Please note that only one relative period is supported, and the combination of start/end dates with a relative period is not allowed.

Copy link

codecov bot commented Jan 6, 2024

Codecov Report

Attention: 69 lines in your changes are missing coverage. Please review.

Comparison is base (9264de8) 66.39% compared to head (97e53f8) 66.39%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #16087      +/-   ##
============================================
- Coverage     66.39%   66.39%   -0.01%     
- Complexity    31529    31541      +12     
============================================
  Files          3507     3507              
  Lines        130575   130628      +53     
  Branches      15242    15250       +8     
============================================
+ Hits          86701    86728      +27     
- Misses        36791    36816      +25     
- Partials       7083     7084       +1     
Flag Coverage Δ
integration 50.28% <3.48%> (-0.02%) ⬇️
integration-h2 32.35% <3.48%> (-0.02%) ⬇️
unit 30.37% <19.76%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rc/main/java/org/hisp/dhis/feedback/ErrorCode.java 100.00% <100.00%> (ø)
...his/analytics/outlier/data/OutlierQueryParams.java 77.27% <100.00%> (+1.08%) ⬆️
...a/org/hisp/dhis/analytics/common/ColumnHeader.java 100.00% <100.00%> (ø)
...sp/dhis/analytics/outlier/data/OutlierRequest.java 0.00% <0.00%> (ø)
...nalytics/outlier/data/OutlierRequestValidator.java 2.32% <0.00%> (-0.12%) ⬇️
...his/analytics/outlier/data/OutlierQueryParser.java 61.70% <22.22%> (-9.36%) ⬇️
.../service/AnalyticsZScoreSqlStatementProcessor.java 50.87% <34.37%> (-3.67%) ⬇️
...ytics/outlier/service/AnalyticsOutlierService.java 0.83% <0.00%> (-0.11%) ⬇️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9264de8...97e53f8. Read the comment docs.

@d-bernat d-bernat changed the title [DRAFT]feat: relative periods and pe dimension support feat: relative periods and pe dimension support Jan 6, 2024
@d-bernat d-bernat added the run-api-analytics-tests Enables analytics e2e tests label Jan 6, 2024
Copy link

sonarcloud bot commented Jan 6, 2024

@d-bernat d-bernat merged commit 1ee00eb into master Jan 8, 2024
17 checks passed
@d-bernat d-bernat deleted the 2.41-DHIS2-16244 branch January 8, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-api-analytics-tests Enables analytics e2e tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants