Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add initial e2e tests for outliers #16098

Merged
merged 15 commits into from
Jan 11, 2024
Merged

test: Add initial e2e tests for outliers #16098

merged 15 commits into from
Jan 11, 2024

Conversation

maikelarabori
Copy link
Contributor

Adds some initial e2e tests for the analytics outliers API.
It covers some random positive scenarios and one negative.

@maikelarabori maikelarabori added the run-api-analytics-tests Enables analytics e2e tests label Jan 8, 2024
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (34da9f9) 66.47% compared to head (1c9ade4) 66.47%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #16098      +/-   ##
============================================
- Coverage     66.47%   66.47%   -0.01%     
  Complexity    31601    31601              
============================================
  Files          3508     3508              
  Lines        130768   130769       +1     
  Branches      15253    15254       +1     
============================================
  Hits          86930    86930              
- Misses        36761    36762       +1     
  Partials       7077     7077              
Flag Coverage Δ
integration 50.27% <0.00%> (-0.01%) ⬇️
integration-h2 32.52% <0.00%> (-0.01%) ⬇️
unit 30.37% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...utlier/service/AnalyticsZScoreOutlierDetector.java 2.85% <0.00%> (-0.09%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34da9f9...1c9ade4. Read the comment docs.

@d-bernat d-bernat changed the title test: Add initial e2e tests for outliers [DRAFT]test: Add initial e2e tests for outliers Jan 9, 2024
@d-bernat d-bernat removed the run-api-analytics-tests Enables analytics e2e tests label Jan 9, 2024
@d-bernat d-bernat added the run-api-analytics-tests Enables analytics e2e tests label Jan 9, 2024
@d-bernat d-bernat changed the title [DRAFT]test: Add initial e2e tests for outliers test: Add initial e2e tests for outliers Jan 9, 2024
Copy link

sonarcloud bot commented Jan 10, 2024

@d-bernat d-bernat merged commit 7ec1cf0 into master Jan 11, 2024
17 checks passed
@d-bernat d-bernat deleted the DHIS2-16246_2.41 branch January 11, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-api-analytics-tests Enables analytics e2e tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants