Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: AuditType failing enum conversion when get tracked entity audits [DHIS2-15805] [ 2.39 ] #16103

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

lucaCambi77
Copy link
Contributor

see #14632

Copy link

sonarcloud bot commented Jan 8, 2024

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 310 lines in your changes are missing coverage. Please review.

Comparison is base (886690f) 58.58% compared to head (08991bc) 64.96%.
Report is 149 commits behind head on 2.39.

Additional details and impacted files
@@             Coverage Diff              @@
##               2.39   #16103      +/-   ##
============================================
+ Coverage     58.58%   64.96%   +6.37%     
- Complexity    25817    28829    +3012     
============================================
  Files          3207     3216       +9     
  Lines        121397   122137     +740     
  Branches      14158    14254      +96     
============================================
+ Hits          71118    79341    +8223     
+ Misses        44340    36270    -8070     
- Partials       5939     6526     +587     
Flag Coverage Δ
integration 49.25% <49.39%> (+0.66%) ⬆️
integration-h2 34.08% <31.41%> (?)
unit 29.64% <42.25%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...main/java/org/hisp/dhis/appmanager/AppManager.java 100.00% <ø> (ø)
...src/main/java/org/hisp/dhis/category/Category.java 65.21% <100.00%> (ø)
.../src/main/java/org/hisp/dhis/common/AuditType.java 100.00% <100.00%> (+10.00%) ⬆️
...ava/org/hisp/dhis/common/BaseAnalyticalObject.java 70.95% <100.00%> (+5.81%) ⬆️
...a/org/hisp/dhis/common/BaseIdentifiableObject.java 80.20% <100.00%> (+1.37%) ⬆️
...s-api/src/main/java/org/hisp/dhis/common/Grid.java 0.00% <ø> (ø)
.../src/main/java/org/hisp/dhis/common/QueryItem.java 68.66% <100.00%> (ø)
...isp/dhis/dataapproval/DataApprovalPermissions.java 91.66% <ø> (+22.43%) ⬆️
...rg/hisp/dhis/dataintegrity/DataIntegrityCheck.java 100.00% <100.00%> (ø)
...isp/dhis/dataintegrity/DataIntegrityCheckType.java 100.00% <100.00%> (+100.00%) ⬆️
... and 109 more

... and 586 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e89dc7...08991bc. Read the comment docs.

@lucaCambi77 lucaCambi77 requested a review from a team January 8, 2024 13:59
@lucaCambi77 lucaCambi77 enabled auto-merge (squash) January 8, 2024 15:21
@lucaCambi77 lucaCambi77 merged commit 756f98b into 2.39 Jan 9, 2024
11 checks passed
@lucaCambi77 lucaCambi77 deleted the DHIS2-15805_2.39 branch January 9, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants