Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: testSearchTokenWithNullLocale fail randomly #16110

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Conversation

vietnguyen
Copy link
Contributor

Attempt to fix below error

org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:31)
	at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:183)
	at org.hisp.dhis.webapi.controller.CrudControllerIntegrationTest.setUpTranslation(CrudControllerIntegrationTest.java:172)
	at org.hisp.dhis.webapi.controller.CrudControllerIntegrationTest.testSearchTokenWithNullLocale(CrudControllerIntegrationTest.java:136)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

Copy link

sonarcloud bot commented Jan 9, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5af3ca5) 66.36% compared to head (cf4e611) 66.45%.
Report is 23 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #16110      +/-   ##
============================================
+ Coverage     66.36%   66.45%   +0.08%     
- Complexity    31515    31580      +65     
============================================
  Files          3507     3508       +1     
  Lines        130571   130713     +142     
  Branches      15235    15251      +16     
============================================
+ Hits          86659    86867     +208     
+ Misses        36840    36768      -72     
- Partials       7072     7078       +6     
Flag Coverage Δ
integration 50.27% <ø> (-0.04%) ⬇️
integration-h2 32.47% <ø> (+0.10%) ⬆️
unit 30.38% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 50 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66dbf95...cf4e611. Read the comment docs.

@maikelarabori maikelarabori self-requested a review January 9, 2024 10:47
@vietnguyen vietnguyen merged commit 91df59a into master Jan 9, 2024
17 checks passed
@vietnguyen vietnguyen deleted the viet-test branch January 9, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants