fix: attributes from TET are exported even when TET is not connected to programs [DHIS2-16397] #16148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to programs [DHIS2-16397]
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #16148 +/- ##
=========================================
Coverage 66.47% 66.48%
- Complexity 31624 31625 +1
=========================================
Files 3513 3513
Lines 131125 131125
Branches 15298 15298
=========================================
+ Hits 87171 87174 +3
+ Misses 36830 36827 -3
Partials 7124 7124
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
enricocolasante
approved these changes
Jan 12, 2024
d-bernat
approved these changes
Jan 12, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of the analytic table export job has a limitation. When processing attributes, the job only exports columns for attributes that are connected to a program. However, this is not entirely accurate. There can be attributes for a Tracked Entity Type (TET) that are not referenced by any program but should still be exported. Fortunately, this issue has been addressed by this pull request (PR) that resolves the problem.