Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Sorting validation and prevent NPE [DHIS2-16369] #16151

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

maikelarabori
Copy link
Contributor

This PR aims to fix the recently added validation of the sorting attribute, in Visualization.
It should also allow dimension's uid present in columns -> items.
I've also made a small improvement to prevent NPEs.

@maikelarabori maikelarabori added the run-api-analytics-tests Enables analytics e2e tests label Jan 11, 2024
@maikelarabori maikelarabori enabled auto-merge (squash) January 11, 2024 21:00
Copy link

sonarcloud bot commented Jan 11, 2024

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8e9425d) 30.37% compared to head (dfe446a) 66.48%.

Additional details and impacted files
@@              Coverage Diff              @@
##             master   #16151       +/-   ##
=============================================
+ Coverage     30.37%   66.48%   +36.11%     
- Complexity    14227    31613    +17386     
=============================================
  Files          3508     3508               
  Lines        130769   130776        +7     
  Branches      15253    15254        +1     
=============================================
+ Hits          39721    86952    +47231     
+ Misses        87464    36754    -50710     
- Partials       3584     7070     +3486     
Flag Coverage Δ
integration 50.27% <63.63%> (?)
integration-h2 32.59% <100.00%> (?)
unit 30.37% <9.09%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...n/java/org/hisp/dhis/common/DimensionalObject.java 92.30% <100.00%> (+7.69%) ⬆️
...ava/org/hisp/dhis/visualization/Visualization.java 51.87% <100.00%> (+22.03%) ⬆️

... and 2180 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e9425d...dfe446a. Read the comment docs.

@maikelarabori maikelarabori merged commit f25e152 into master Jan 12, 2024
17 checks passed
@maikelarabori maikelarabori deleted the DHIS2-16369_2.41 branch January 12, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-api-analytics-tests Enables analytics e2e tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants