Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CPL - added support for missing operators [DHIS2-16459] #16185

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

gnespolino
Copy link
Contributor

@gnespolino gnespolino commented Jan 16, 2024

This PR adds support for NE, IEQ and !IEQ operators in CPL as they were not already implemented

@gnespolino gnespolino changed the title feat: CPL - added missing support for case insensitive operators [DHIS2-16459] feat: CPL - added missing support for missing operators [DHIS2-16459] Jan 16, 2024
@gnespolino gnespolino added the run-api-analytics-tests Enables analytics e2e tests label Jan 16, 2024
@gnespolino gnespolino changed the title feat: CPL - added missing support for missing operators [DHIS2-16459] feat: CPL - added support for missing operators [DHIS2-16459] Jan 16, 2024
Copy link

sonarqubecloud bot commented Jan 16, 2024

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (312f80c) 49.65% compared to head (86f48d6) 66.47%.

Additional details and impacted files
@@              Coverage Diff              @@
##             master   #16185       +/-   ##
=============================================
+ Coverage     49.65%   66.47%   +16.82%     
- Complexity    23555    31625     +8070     
=============================================
  Files          3513     3514        +1     
  Lines        131127   131135        +8     
  Branches      15298    15300        +2     
=============================================
+ Hits          65108    87178    +22070     
+ Misses        59900    36830    -23070     
- Partials       6119     7127     +1008     
Flag Coverage Δ
integration 50.01% <6.66%> (?)
integration-h2 32.64% <6.66%> (-0.01%) ⬇️
unit 30.37% <60.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rc/main/java/org/hisp/dhis/feedback/ErrorCode.java 100.00% <100.00%> (ø)
...isp/dhis/analytics/common/query/LowerRenderer.java 100.00% <100.00%> (ø)
...nalytics/common/query/BinaryConditionRenderer.java 83.63% <57.14%> (-4.12%) ⬇️
...analytics/common/query/ConstantValuesRenderer.java 77.77% <50.00%> (ø)

... and 1241 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 312f80c...86f48d6. Read the comment docs.

@gnespolino gnespolino merged commit 52598b5 into master Jan 16, 2024
20 checks passed
@gnespolino gnespolino deleted the DHIS2-16459_IEQ_!IEQ_operators branch January 16, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-api-analytics-tests Enables analytics e2e tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants