Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clean HibernateSequentialNumberCounterStoreTest flaky tests #16202

Merged
merged 3 commits into from
Jan 18, 2024

Conversation

lucaCambi77
Copy link
Contributor

@lucaCambi77 lucaCambi77 commented Jan 17, 2024

Following a test failing, with this PR, we do some cleanup in HibernateSequentialNumberCounterStoreTest.

  • Remove the DummyService class used only for testing.
  • Make the testing more clear with @ParameterizedTest
  • Remove the unnecessary uid random generation for a few tests.

@lucaCambi77 lucaCambi77 requested review from gnespolino, stian-sandvold and a team January 17, 2024 15:07
Copy link

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (312f80c) 49.65% compared to head (08c851c) 66.48%.
Report is 5 commits behind head on master.

Additional details and impacted files
@@              Coverage Diff              @@
##             master   #16202       +/-   ##
=============================================
+ Coverage     49.65%   66.48%   +16.83%     
- Complexity    23555    31628     +8073     
=============================================
  Files          3513     3514        +1     
  Lines        131127   131139       +12     
  Branches      15298    15296        -2     
=============================================
+ Hits          65108    87185    +22077     
+ Misses        59900    36832    -23068     
- Partials       6119     7122     +1003     
Flag Coverage Δ
integration 50.00% <100.00%> (?)
integration-h2 32.67% <0.00%> (+0.02%) ⬆️
unit 30.37% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...bernate/HibernateSequentialNumberCounterStore.java 100.00% <100.00%> (+100.00%) ⬆️

... and 1257 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 312f80c...08c851c. Read the comment docs.

Copy link
Contributor

@gnespolino gnespolino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lucaCambi77 lucaCambi77 merged commit db28163 into master Jan 18, 2024
17 checks passed
@lucaCambi77 lucaCambi77 deleted the RV_SEQUENTIAL_CLEAN branch January 18, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants