Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add API ping request ignoring config #16212

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

netroms
Copy link
Contributor

@netroms netroms commented Jan 18, 2024

Summary

Adds back, configuration to ignore authentication on calls to /api/ping endpoint. This was lost during the migration to non deprecated Spring security config.

Manual test

  1. Call endpoint /api/ping (without being logged in first)
  2. Observe call is executed and returns 200

Copy link

@david-mackessy
Copy link
Contributor

david-mackessy commented Jan 18, 2024

having a test for it would mean we would catch it if it's ever mistakenly changed in future

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0b2fe0d) 66.53% compared to head (c56fb38) 66.54%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #16212   +/-   ##
=========================================
  Coverage     66.53%   66.54%           
- Complexity    31697    31701    +4     
=========================================
  Files          3519     3519           
  Lines        131328   131331    +3     
  Branches      15303    15303           
=========================================
+ Hits          87385    87391    +6     
+ Misses        36817    36815    -2     
+ Partials       7126     7125    -1     
Flag Coverage Δ
integration 50.07% <0.00%> (+<0.01%) ⬆️
integration-h2 32.68% <100.00%> (+<0.01%) ⬆️
unit 30.34% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...i/security/config/DhisWebApiWebSecurityConfig.java 93.06% <100.00%> (+0.05%) ⬆️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b2fe0d...c56fb38. Read the comment docs.

@larshelge larshelge merged commit 3256343 into master Jan 18, 2024
17 checks passed
@larshelge larshelge deleted the DHIS2_16169_chore_fix_ping_ignore_2.41 branch January 18, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants