Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: return pagination fields in page objects in /programNotificationInstances TECH-1683 #16245

Merged
merged 4 commits into from
Jan 22, 2024

Conversation

teleivo
Copy link
Contributor

@teleivo teleivo commented Jan 22, 2024

We will align the controller and its request parameters with tracker exporters at a later stage. Right now we have to duplicate some of the validation logic we have in the RequestParamsValidator.

@teleivo teleivo enabled auto-merge (squash) January 22, 2024 12:27
Copy link

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (4f26fd4) 66.56% compared to head (79f445a) 66.55%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #16245      +/-   ##
============================================
- Coverage     66.56%   66.55%   -0.01%     
- Complexity    31651    31656       +5     
============================================
  Files          3517     3517              
  Lines        130972   130979       +7     
  Branches      15297    15297              
============================================
- Hits          87180    87175       -5     
- Misses        36664    36678      +14     
+ Partials       7128     7126       -2     
Flag Coverage Δ
integration 50.21% <14.28%> (-0.01%) ⬇️
integration-h2 32.59% <95.23%> (-0.01%) ⬇️
unit 30.38% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ion/HibernateProgramNotificationInstanceStore.java 90.32% <100.00%> (+5.94%) ⬆️
...r/event/ProgramNotificationInstanceController.java 97.29% <94.44%> (+0.74%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f26fd4...79f445a. Read the comment docs.

@teleivo teleivo merged commit 99464de into master Jan 22, 2024
17 checks passed
@teleivo teleivo deleted the TECH-1683 branch January 22, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants