fix: make sure background threads check for not logged in current user #16402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #16402 +/- ##
============================================
+ Coverage 66.68% 66.70% +0.02%
- Complexity 31767 31780 +13
============================================
Files 3529 3530 +1
Lines 131105 131169 +64
Branches 15263 15272 +9
============================================
+ Hits 87428 87502 +74
+ Misses 36555 36542 -13
- Partials 7122 7125 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 30 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
jbee
approved these changes
Feb 2, 2024
dhis-2/dhis-test-integration/src/test/java/org/hisp/dhis/message/MessageServiceTest.java
Outdated
Show resolved
Hide resolved
david-mackessy
approved these changes
Feb 2, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After the user refactoring in #15727, some places where a separate/background thread is accessing the current user, it will fail because they now have to check for absence of/no user, before calling
CurrentUserUtil.getCurrentUserDetails/getCurrentUsername.This PR fixes one such issue in the
DefaultMessageService.Automatic test
MessageServiceTest#testSendMessageWithNoCurrentUser()