Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reject invalid order parameter values DHIS2-16935 #16673

Merged
merged 9 commits into from
Mar 4, 2024

test: clean

6b479be
Select commit
Loading
Failed to load commit list.
Merged

fix: reject invalid order parameter values DHIS2-16935 #16673

test: clean
6b479be
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 4, 2024 in 0s

66.92% (+0.00%) compared to 9eb5407

View this Pull Request on Codecov

66.92% (+0.00%) compared to 9eb5407

Details

Codecov Report

Attention: Patch coverage is 85.29412% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 66.92%. Comparing base (9eb5407) to head (6b479be).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #16673   +/-   ##
=========================================
  Coverage     66.92%   66.92%           
- Complexity    32035    32036    +1     
=========================================
  Files          3552     3550    -2     
  Lines        131537   131554   +17     
  Branches      15315    15321    +6     
=========================================
+ Hits          88031    88043   +12     
- Misses        36346    36348    +2     
- Partials       7160     7163    +3     
Files Coverage Δ
...api/controller/event/webrequest/OrderCriteria.java 94.44% <100.00%> (+1.11%) ⬆️
...p/dhis/webapi/controller/CrudControllerAdvice.java 67.39% <79.16%> (+0.72%) ⬆️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9eb5407...6b479be. Read the comment docs.