fix: reject invalid order parameter values DHIS2-16935 [2.40] #16713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teleivo
force-pushed
the
DHIS2-16935-2.40
branch
from
e2bfa48 to
30fce5b
Compare
teleivo
force-pushed
the
DHIS2-16935-2.40
branch
from
30fce5b to
835e80d
Compare
|
teleivo
changed the title
jbee
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #16673
StringToOrderCriteriaListConverter.javawhich was not used in < 2.40 instead of theOrderCriteriaParamEditorin 2.412.39 and older
Older versions also suffer from this bug. Behavior is likely as for 2.40.3 described in table https://dhis2.atlassian.net/browse/DHIS2-16935. We have not backported many of the changes that this fix relies on in the
CrudControllerAdvice. For us to fix the behavior in older versions we would need to backport these changes first. We will wait for @enricocolasante to decide if/how to backport any changes and a fix.