fix: use tracker importer in TrackerEventSMSListener DHIS2-17729

[teleivo]

As a reference this is the event saving logic before we made our changes to sms processing. You can see that users were able to create and update an event.

This is how the TrackerEventSmsSubmission sms is encoded. If you navigate further down you can find out which fields are mandatory. Mandatory are (meaning you'll get an NPE if you don't provide them): ids and eventStatus. For data values we also have to provide a category option combo 🤷🏻 (that only affects our tests).

• use the tracker importer
  • EventTrackerConverterService sets completedBy/Date when an event status transitions to COMPLETED
  • no need to look up metadata as this is done by the importer
  • no need to look up whether the event is new/exists as this is done by the importer
• add a test for creating and for updating an event
• fix error message OccurredAt should be the field occurredAt
• fix message formatter: the error No event can transition from status 'ACTIVE' to status 'OVERDUE'. was No event can transition from status '' to status ''. before. Not sure why we defaulted to "" instead of Object.toString() 🤔

Questions

• The geometry sent via sms is always a point. This is limited by the sms-compression library. The program/programStage can have different FeatureTypes. I assume the sms is rejected if the metadata feature type is misconfigured.
• The sms-compression does not allow not setting the events uid. I cannot encode such an sms. So I don't get why there is logic regarding getting or not getting a UID 🤷🏻. See this which throws an NPE if I do not provide an id.

Next

These are the tracker related compression based SMS we need to adapt so they use the importer:

SubmissionType => Listener class processing these types of SMS

• DELETE => DeleteEventListener ✅ (fix: processing sms and test tracker event deletion DHIS2-17729 #18473)
• ENROLLMENT => EnrollmentSMSListener
• RELATIONSHIP => RelationshipSMSListener ✅ (fix: use tracker importer in RelationshipSMSListener DHIS2-17729 #18509)
• SIMPLE_EVENT => SimpleEventSMSListener
• TRACKER_EVENT => TrackerEventSMSListener ✅ (this PR)

The above can be used used by Android when users are offline.

Then there are command based SMS listeners we need to adapt so they use the importer:

• TRACKED_ENTITY_REGISTRATION_PARSER => TrackedEntityRegistrationSMSListener
• PROGRAM_STAGE_DATAENTRY_PARSER => ProgramStageDataEntrySMSListener
• EVENT_REGISTRATION_PARSER => SingleEventListener

[sonarcloud]

Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud