-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement login page #18803
feat: implement login page #18803
Conversation
dhis-2/dhis-web-api/src/main/resources/org/hisp/dhis/webapi/servlet/login.html
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 🤩. It looks like it's working quite well. I think the most important thing is just to add the 2fa field in case users have that enabled.
dhis-2/dhis-web-api/src/main/resources/org/hisp/dhis/webapi/servlet/login.html
Outdated
Show resolved
Hide resolved
dhis-2/dhis-web-api/src/main/resources/org/hisp/dhis/webapi/servlet/login.html
Outdated
Show resolved
Hide resolved
dhis-2/dhis-web-api/src/main/resources/org/hisp/dhis/webapi/servlet/login.html
Outdated
Show resolved
Hide resolved
dhis-2/dhis-web-api/src/main/resources/org/hisp/dhis/webapi/servlet/login.html
Outdated
Show resolved
Hide resolved
dhis-2/dhis-web-api/src/main/resources/org/hisp/dhis/webapi/servlet/login.html
Outdated
Show resolved
Hide resolved
dhis-2/dhis-web-api/src/main/resources/org/hisp/dhis/webapi/servlet/login.html
Outdated
Show resolved
Hide resolved
dhis-2/dhis-web-api/src/main/resources/org/hisp/dhis/webapi/servlet/login.html
Show resolved
Hide resolved
dhis-2/dhis-web-api/src/main/resources/org/hisp/dhis/webapi/servlet/login.html
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 🚀
…114/fallback-login
Quality Gate passedIssues Measures |
Implements DHIS2-18114
Description
This PR introduces a simple HTML login page that will be served by the backend as a backup for the current login system. This implementation serves as a fallback in case the main login system is unavailable. It uses plain HTML, CSS, and JavaScript for basic user authentication flow.
Checklist
All points above should be relevant for feature PRs. For bugfixes, some points might not be relevant. In that case, just check them anyway to signal the work is done.
Screenshots