Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement login page #18803

Merged
merged 11 commits into from
Oct 25, 2024
Merged

feat: implement login page #18803

merged 11 commits into from
Oct 25, 2024

Conversation

Chisomchima
Copy link
Member

@Chisomchima Chisomchima commented Oct 11, 2024

Implements DHIS2-18114

Description

This PR introduces a simple HTML login page that will be served by the backend as a backup for the current login system. This implementation serves as a fallback in case the main login system is unavailable. It uses plain HTML, CSS, and JavaScript for basic user authentication flow.


Checklist

  • Added an HTML file (backup-login.html) to provide a basic login interface with fields for username and password.
  • The form uses simple JavaScript to handle form submission, sending credentials to the "/api/auth/login" endpoint via a POST request.
  • Basic error handling is implemented to display an error message on invalid login attempts.

All points above should be relevant for feature PRs. For bugfixes, some points might not be relevant. In that case, just check them anyway to signal the work is done.


Screenshots

Screenshot 2024-10-16 at 08 26 52

@Chisomchima Chisomchima requested a review from a team as a code owner October 11, 2024 07:15
@Chisomchima Chisomchima requested a review from tomzemp October 15, 2024 13:19
Copy link
Member

@tomzemp tomzemp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🤩. It looks like it's working quite well. I think the most important thing is just to add the 2fa field in case users have that enabled.

Copy link
Member

@tomzemp tomzemp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

Copy link

sonarcloud bot commented Oct 25, 2024

@Chisomchima Chisomchima merged commit 5e4b6bf into master Oct 25, 2024
15 checks passed
@Chisomchima Chisomchima deleted the DHIS2-18114/fallback-login branch October 25, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants