fix: [DHIS2-18527] (2.40) Fix deleted relationship getting returned in event #19397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
muilpp
approved these changes
Dec 6, 2024
@muilpp Good point Marc! I had forgotten about that and did not find any references for includeDeleted in the relationships area. It could be that that parameter was never respected in the relationship side of things so far. I'll create a separate jira issue to track/test that 👍 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In event fetching API (
api/tracker/event/{uid}) , whenincludeRelationshipis set to true. The service fetches all relationships without respecting thedeletedflag.This PR corrects this.
In collection event fetching API (
api/tracker/events=event={uid}) this issue does not exist.