fix: Unable to save outbound sms during async operation [DHIS2-18586] #19415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| @@ -292,7 +286,12 @@ private void handleResponse(OutboundMessageResponse status, OutboundSms sms) { | |||
| sms.setStatus(OutboundSmsStatus.FAILED); | |||
| } | |||
|
|
|||
| outboundSmsService.save(sms); | |||
| try { | |||
There was a problem hiding this comment.
Who is calling this method?
Why the user is not present?
This doesn't seem to be running in another thread, if I am wrong, who is starting the thread?
There was a problem hiding this comment.
Who is calling this method?
Why the user is not present?
because this is an async operation.
This doesn't seem to be running in another thread, if I am wrong, who is starting the thread?
| @@ -122,7 +123,7 @@ public OutboundMessageResponse sendMessage( | |||
| public Future<OutboundMessageResponse> sendMessageAsync( | |||
| String subject, String text, String footer, User sender, Set<User> users, boolean forceSend) { | |||
| OutboundMessageResponse response = sendMessage(subject, text, footer, sender, users, forceSend); | |||
| return new AsyncResult<>(response); | |||
| return CompletableFuture.completedFuture(response); | |||
There was a problem hiding this comment.
This is doing nothing, it is not running sendMessage in a different thread and it is not running it in parallel.
Would it make sense to just return the response?
ameenhere
approved these changes
Dec 13, 2024
enricocolasante
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DHIS2-18586
Async operation tries to save outboundSMS and it fails due to currentUser not set. This PR injects currentUser using AuthenticationService.