fix: Use SqlBuilder for if-then-else logic [DHIS2-18417] #19472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larshelge
changed the title
larshelge
requested review from
luciano-fiandesio,
maikelarabori and
gnespolino
and removed request for
maikelarabori
larshelge
changed the title
|
gnespolino
reviewed
Dec 16, 2024
|
We have multi-if statements in some places but I plan to create another overloaded method for that later. |
gnespolino
approved these changes
Dec 16, 2024
maikelarabori
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the conditional if-then-else logic behind
SqlBuilderto allow for differences across analytics databases.