fix: main dimensions not translated in line lists (DHIS2-15878) #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-502--dhis2-line-listing.netlify.app |
Passing run #2677 ↗︎
Details:
Review all test suite changes for PR #502 ↗︎ |
|||||||||||||||
edoardo
approved these changes
Apr 22, 2024
janhenrikoverland
approved these changes
Apr 24, 2024
|
@martinkrulltott creates a new ticket for time dimensions. |
dhis2-bot
added a commit
that referenced
this pull request
Apr 24, 2024
## [100.16.2](v100.16.1...v100.16.2) (2024-04-24) ### Bug Fixes * main dimensions not translated in line lists (DHIS2-15878) ([#502](#502)) ([d3639b2](d3639b2))
|
🎉 This PR is included in version 100.16.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements DHIS2-15878
Key features
Description
Some main dimensions were previously not translated properly, as they would fall back to the
columnfield in the response header instead of using custom metadata. This caused the table header to display non-translated labels (even though the layout and dimension lists were translated properly).(🟢 = previously broken, now fixed. 🔵 = was already working, 🟡 = separate ticket)
Input: Event
Input: Enrollment
Input: Tracked Entity
TODO
Known issues
Screenshots
event
enrollment
tracked entity