-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: zoom to map content on dashboard item resize #3440
Open
BRaimbault
wants to merge
5
commits into
master
Choose a base branch
from
feat/DHIS2-18641
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
29b2541
feat: fitBound of map on plugin resize
BRaimbault 7c4e903
chore: bump cypress to v13.17.0
BRaimbault efc0ba5
chore: update eventlayer cypress test
BRaimbault b781ff3
Merge branch 'master' into feat/DHIS2-18641
BRaimbault 6e44bf1
chore: correct parameter passed to onFullscreenChange
BRaimbault File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1404,27 +1404,27 @@ | |
through2 "^2.0.0" | ||
watchify "^4.0.0" | ||
|
||
"@cypress/request@^2.88.10": | ||
version "2.88.11" | ||
resolved "https://registry.yarnpkg.com/@cypress/request/-/request-2.88.11.tgz#5a4c7399bc2d7e7ed56e92ce5acb620c8b187047" | ||
integrity sha512-M83/wfQ1EkspjkE2lNWNV5ui2Cv7UCv1swW1DqljahbzLVWltcsexQh8jYtuS/vzFXP+HySntGM83ZXA9fn17w== | ||
"@cypress/request@^3.0.6": | ||
version "3.0.7" | ||
resolved "https://registry.yarnpkg.com/@cypress/request/-/request-3.0.7.tgz#6a74a4da98d9e5ae9121d6e2d9c14780c9b5cf1a" | ||
integrity sha512-LzxlLEMbBOPYB85uXrDqvD4MgcenjRBLIns3zyhx7vTPj/0u2eQhzXvPiGcaJrV38Q9dbkExWp6cOHPJ+EtFYg== | ||
dependencies: | ||
aws-sign2 "~0.7.0" | ||
aws4 "^1.8.0" | ||
caseless "~0.12.0" | ||
combined-stream "~1.0.6" | ||
extend "~3.0.2" | ||
forever-agent "~0.6.1" | ||
form-data "~2.3.2" | ||
http-signature "~1.3.6" | ||
form-data "~4.0.0" | ||
http-signature "~1.4.0" | ||
is-typedarray "~1.0.0" | ||
isstream "~0.1.2" | ||
json-stringify-safe "~5.0.1" | ||
mime-types "~2.1.19" | ||
performance-now "^2.1.0" | ||
qs "~6.10.3" | ||
qs "6.13.1" | ||
safe-buffer "^5.1.2" | ||
tough-cookie "~2.5.0" | ||
tough-cookie "^5.0.0" | ||
tunnel-agent "^0.6.0" | ||
uuid "^8.3.2" | ||
|
||
|
@@ -3970,11 +3970,6 @@ | |
resolved "https://registry.yarnpkg.com/@types/node/-/node-18.14.2.tgz#c076ed1d7b6095078ad3cf21dfeea951842778b1" | ||
integrity sha512-1uEQxww3DaghA0RxqHx0O0ppVlo43pJhepY51OxuQIKHpjbnYLA7vcdwioNPzIqmC2u3I/dmylcqjlh0e7AyUA== | ||
|
||
"@types/node@^14.14.31": | ||
version "14.18.36" | ||
resolved "https://registry.yarnpkg.com/@types/node/-/node-14.18.36.tgz#c414052cb9d43fab67d679d5f3c641be911f5835" | ||
integrity sha512-FXKWbsJ6a1hIrRxv+FoukuHnGTgEzKYGi7kilfMae96AL9UNkPFNWJEEYWzdRI9ooIkbr4AKldyuSTLql06vLQ== | ||
|
||
"@types/normalize-package-data@^2.4.0", "@types/normalize-package-data@^2.4.1": | ||
version "2.4.4" | ||
resolved "https://registry.yarnpkg.com/@types/normalize-package-data/-/normalize-package-data-2.4.4.tgz#56e2cc26c397c038fab0e3a917a12d5c5909e901" | ||
|
@@ -5662,7 +5657,7 @@ buffer-xor@^1.0.3: | |
resolved "https://registry.yarnpkg.com/buffer-xor/-/buffer-xor-1.0.3.tgz#26e61ed1422fb70dd42e6e36729ed51d855fe8d9" | ||
integrity sha512-571s0T7nZWK6vB67HI5dyUF7wXiNcfaPPPTl6zYCNApANjIvYJTg7hlud/+cJpdAhS7dVzqMLmfhfHR3rAcOjQ== | ||
|
||
buffer@^5.1.0, buffer@^5.5.0, buffer@^5.6.0: | ||
buffer@^5.1.0, buffer@^5.5.0, buffer@^5.7.1: | ||
version "5.7.1" | ||
resolved "https://registry.yarnpkg.com/buffer/-/buffer-5.7.1.tgz#ba62e7c13133053582197160851a8f648e99eed0" | ||
integrity sha512-EHcyIPBQ4BSGlvjB16k5KgAJ27CIsHY/2JBmCRReo48y9rQ3MaUzWX3KVlBa4U7MyX02HdVj0K7C3WaB3ju7FQ== | ||
|
@@ -5973,6 +5968,11 @@ ci-info@^3.2.0: | |
resolved "https://registry.yarnpkg.com/ci-info/-/ci-info-3.8.0.tgz#81408265a5380c929f0bc665d62256628ce9ef91" | ||
integrity sha512-eXTggHWSooYhq49F2opQhuHWgzucfF2YgODK4e1566GQs5BIfP30B0oenwBJHfWxAs2fyPB1s7Mg949zLf61Yw== | ||
|
||
ci-info@^4.0.0: | ||
version "4.1.0" | ||
resolved "https://registry.yarnpkg.com/ci-info/-/ci-info-4.1.0.tgz#92319d2fa29d2620180ea5afed31f589bc98cf83" | ||
integrity sha512-HutrvTNsF48wnxkzERIXOe5/mlcfFcbfCmwcg6CJnizbSue78AbDt+1cgl26zwn61WFxhcPykPfZrbqjGmBb4A== | ||
|
||
cidr-regex@^3.1.1: | ||
version "3.1.1" | ||
resolved "https://registry.yarnpkg.com/cidr-regex/-/cidr-regex-3.1.1.tgz#ba1972c57c66f61875f18fd7dd487469770b571d" | ||
|
@@ -6933,23 +6933,23 @@ cypress-wait-until@^1.7.2: | |
resolved "https://registry.yarnpkg.com/cypress-wait-until/-/cypress-wait-until-1.7.2.tgz#7f534dd5a11c89b65359e7a0210f20d3dfc22107" | ||
integrity sha512-uZ+M8/MqRcpf+FII/UZrU7g1qYZ4aVlHcgyVopnladyoBrpoaMJ4PKZDrdOJ05H5RHbr7s9Tid635X3E+ZLU/Q== | ||
|
||
cypress@^12.16.0: | ||
version "12.16.0" | ||
resolved "https://registry.yarnpkg.com/cypress/-/cypress-12.16.0.tgz#d0dcd0725a96497f4c60cf54742242259847924c" | ||
integrity sha512-mwv1YNe48hm0LVaPgofEhGCtLwNIQEjmj2dJXnAkY1b4n/NE9OtgPph4TyS+tOtYp5CKtRmDvBzWseUXQTjbTg== | ||
cypress@^13.17.0: | ||
version "13.17.0" | ||
resolved "https://registry.yarnpkg.com/cypress/-/cypress-13.17.0.tgz#34c3d68080c4497eace0f353bd1629587a5f600d" | ||
integrity sha512-5xWkaPurwkIljojFidhw8lFScyxhtiFHl/i/3zov+1Z5CmY4t9tjIdvSXfu82Y3w7wt0uR9KkucbhkVvJZLQSA== | ||
dependencies: | ||
"@cypress/request" "^2.88.10" | ||
"@cypress/request" "^3.0.6" | ||
"@cypress/xvfb" "^1.2.4" | ||
"@types/node" "^14.14.31" | ||
"@types/sinonjs__fake-timers" "8.1.1" | ||
"@types/sizzle" "^2.3.2" | ||
arch "^2.2.0" | ||
blob-util "^2.0.2" | ||
bluebird "^3.7.2" | ||
buffer "^5.6.0" | ||
buffer "^5.7.1" | ||
cachedir "^2.3.0" | ||
chalk "^4.1.0" | ||
check-more-types "^2.24.0" | ||
ci-info "^4.0.0" | ||
cli-cursor "^3.1.0" | ||
cli-table3 "~0.6.1" | ||
commander "^6.2.1" | ||
|
@@ -6964,7 +6964,6 @@ cypress@^12.16.0: | |
figures "^3.2.0" | ||
fs-extra "^9.1.0" | ||
getos "^3.2.1" | ||
is-ci "^3.0.0" | ||
is-installed-globally "~0.4.0" | ||
lazy-ass "^1.6.0" | ||
listr2 "^3.8.3" | ||
|
@@ -6973,11 +6972,13 @@ cypress@^12.16.0: | |
minimist "^1.2.8" | ||
ospath "^1.2.2" | ||
pretty-bytes "^5.6.0" | ||
process "^0.11.10" | ||
proxy-from-env "1.0.0" | ||
request-progress "^3.0.0" | ||
semver "^7.3.2" | ||
semver "^7.5.3" | ||
supports-color "^8.1.1" | ||
tmp "~0.2.1" | ||
tmp "~0.2.3" | ||
tree-kill "1.2.2" | ||
untildify "^4.0.0" | ||
yauzl "^2.10.0" | ||
|
||
|
@@ -8979,6 +8980,15 @@ form-data@~2.3.2: | |
combined-stream "^1.0.6" | ||
mime-types "^2.1.12" | ||
|
||
form-data@~4.0.0: | ||
version "4.0.1" | ||
resolved "https://registry.yarnpkg.com/form-data/-/form-data-4.0.1.tgz#ba1076daaaa5bfd7e99c1a6cb02aa0a5cff90d48" | ||
integrity sha512-tzN8e4TX8+kkxGPK8D5u0FNmjPUjw3lwC9lSLxxoB/+GtsJG91CO8bSWy73APlgAZzZbXEYZJuxjkHH2w+Ezhw== | ||
dependencies: | ||
asynckit "^0.4.0" | ||
combined-stream "^1.0.8" | ||
mime-types "^2.1.12" | ||
|
||
[email protected]: | ||
version "0.2.0" | ||
resolved "https://registry.yarnpkg.com/forwarded/-/forwarded-0.2.0.tgz#2269936428aad4c15c7ebe9779a84bf0b2a81811" | ||
|
@@ -9874,14 +9884,14 @@ http-signature@~1.2.0: | |
jsprim "^1.2.2" | ||
sshpk "^1.7.0" | ||
|
||
http-signature@~1.3.6: | ||
version "1.3.6" | ||
resolved "https://registry.yarnpkg.com/http-signature/-/http-signature-1.3.6.tgz#cb6fbfdf86d1c974f343be94e87f7fc128662cf9" | ||
integrity sha512-3adrsD6zqo4GsTqtO7FyrejHNv+NgiIfAfv68+jVlFmSr9OGy7zrxONceFRLKvnnZA5jbxQBX1u9PpB6Wi32Gw== | ||
http-signature@~1.4.0: | ||
version "1.4.0" | ||
resolved "https://registry.yarnpkg.com/http-signature/-/http-signature-1.4.0.tgz#dee5a9ba2bf49416abc544abd6d967f6a94c8c3f" | ||
integrity sha512-G5akfn7eKbpDN+8nPS/cb57YeA1jLTVxjpCj7tmm3QKPdyDy7T+qSC40e9ptydSWvkwjSXw1VbkpyEm39ukeAg== | ||
dependencies: | ||
assert-plus "^1.0.0" | ||
jsprim "^2.0.2" | ||
sshpk "^1.14.1" | ||
sshpk "^1.18.0" | ||
|
||
https-browserify@^1.0.0: | ||
version "1.0.0" | ||
|
@@ -10323,13 +10333,6 @@ is-ci@^2.0.0: | |
dependencies: | ||
ci-info "^2.0.0" | ||
|
||
is-ci@^3.0.0: | ||
version "3.0.1" | ||
resolved "https://registry.yarnpkg.com/is-ci/-/is-ci-3.0.1.tgz#db6ecbed1bd659c43dac0f45661e7674103d1867" | ||
integrity sha512-ZYvCgrefwqoQ6yTyYUbQu64HsITZ3NfKX1lzaEYdkTDcfKzzCI/wthRRYKkdjHKFVgNiXKAKm65Zo1pk2as/QQ== | ||
dependencies: | ||
ci-info "^3.2.0" | ||
|
||
is-cidr@^4.0.2: | ||
version "4.0.2" | ||
resolved "https://registry.yarnpkg.com/is-cidr/-/is-cidr-4.0.2.tgz#94c7585e4c6c77ceabf920f8cde51b8c0fda8814" | ||
|
@@ -14525,7 +14528,7 @@ process-nextick-args@^2.0.0, process-nextick-args@~2.0.0: | |
resolved "https://registry.yarnpkg.com/process-nextick-args/-/process-nextick-args-2.0.1.tgz#7820d9b16120cc55ca9ae7792680ae7dba6d7fe2" | ||
integrity sha512-3ouUOpQhtgrbOa17J7+uxOTpITYWaGP7/AhoR3+A+/1e9skrzelGi/dXzEYyvbxubEF6Wn2ypscTKiKJFFn1ag== | ||
|
||
process@~0.11.0: | ||
process@^0.11.10, process@~0.11.0: | ||
version "0.11.10" | ||
resolved "https://registry.yarnpkg.com/process/-/process-0.11.10.tgz#7332300e840161bda3e69a1d1d91a7d4bc16f182" | ||
integrity sha512-cdGef/drWFoydD1JsMzuFf8100nZl+GT+yacc2bEced5f9Rjk4z+WtFUTBu9PhOi9j/jfmBPu0mMEY4wIdAF8A== | ||
|
@@ -14712,12 +14715,12 @@ [email protected]: | |
dependencies: | ||
side-channel "^1.0.6" | ||
|
||
qs@~6.10.3: | ||
version "6.10.5" | ||
resolved "https://registry.yarnpkg.com/qs/-/qs-6.10.5.tgz#974715920a80ff6a262264acd2c7e6c2a53282b4" | ||
integrity sha512-O5RlPh0VFtR78y79rgcgKK4wbAI0C5zGVLztOIdpWX6ep368q5Hv6XRxDvXuZ9q3C6v+e3n8UfZZJw7IIG27eQ== | ||
qs@6.13.1: | ||
version "6.13.1" | ||
resolved "https://registry.yarnpkg.com/qs/-/qs-6.13.1.tgz#3ce5fc72bd3a8171b85c99b93c65dd20b7d1b16e" | ||
integrity sha512-EJPeIn0CYrGu+hli1xilKAPXODtJ12T0sP63Ijx2/khC2JtuaN3JyNIpvmnkmaEtha9ocbG4A4cMcr+TvqvwQg== | ||
dependencies: | ||
side-channel "^1.0.4" | ||
side-channel "^1.0.6" | ||
|
||
qs@~6.5.2: | ||
version "6.5.3" | ||
|
@@ -15906,6 +15909,11 @@ semver@^7.0.0, semver@^7.1.1, semver@^7.1.2, semver@^7.2.1, semver@^7.3.2, semve | |
resolved "https://registry.yarnpkg.com/semver/-/semver-7.6.2.tgz#1e3b34759f896e8f14d6134732ce798aeb0c6e13" | ||
integrity sha512-FNAIBWCx9qcRhoHcgcJ0gvU7SN1lYU2ZXuSfl04bSC5OpvDHFyJCjdNHomPXxjQlCBU67YW64PzY7/VIEH7F2w== | ||
|
||
semver@^7.5.3: | ||
version "7.6.3" | ||
resolved "https://registry.yarnpkg.com/semver/-/semver-7.6.3.tgz#980f7b5550bc175fb4dc09403085627f9eb33143" | ||
integrity sha512-oVekP1cKtI+CTDvHWYFUcMtsK/00wmAEfyqKfNdARm8u1wNVhSgaX7A8d4UuIlUI5e84iEwOhs7ZPYRmzU9U6A== | ||
|
||
[email protected]: | ||
version "0.19.0" | ||
resolved "https://registry.yarnpkg.com/send/-/send-0.19.0.tgz#bbc5a388c8ea6c048967049dbeac0e4a3f09d7f8" | ||
|
@@ -16388,7 +16396,22 @@ sprintf-js@~1.0.2: | |
resolved "https://registry.yarnpkg.com/sprintf-js/-/sprintf-js-1.0.3.tgz#04e6926f662895354f3dd015203633b857297e2c" | ||
integrity sha512-D9cPgkvLlV3t3IzL0D0YLvGA9Ahk4PcvVwUbN0dSGr1aP0Nrt4AEnTUbuGvquEC0mA64Gqt1fzirlRs5ibXx8g== | ||
|
||
sshpk@^1.14.1, sshpk@^1.7.0: | ||
sshpk@^1.18.0: | ||
version "1.18.0" | ||
resolved "https://registry.yarnpkg.com/sshpk/-/sshpk-1.18.0.tgz#1663e55cddf4d688b86a46b77f0d5fe363aba028" | ||
integrity sha512-2p2KJZTSqQ/I3+HX42EpYOa2l3f8Erv8MWKsy2I9uf4wA7yFIkXRffYdsx86y6z4vHtV8u7g+pPlr8/4ouAxsQ== | ||
dependencies: | ||
asn1 "~0.2.3" | ||
assert-plus "^1.0.0" | ||
bcrypt-pbkdf "^1.0.0" | ||
dashdash "^1.12.0" | ||
ecc-jsbn "~0.1.1" | ||
getpass "^0.1.1" | ||
jsbn "~0.1.0" | ||
safer-buffer "^2.0.2" | ||
tweetnacl "~0.14.0" | ||
|
||
sshpk@^1.7.0: | ||
version "1.17.0" | ||
resolved "https://registry.yarnpkg.com/sshpk/-/sshpk-1.17.0.tgz#578082d92d4fe612b13007496e543fa0fbcbe4c5" | ||
integrity sha512-/9HIEs1ZXGhSPE8X6Ccm7Nam1z8KcoCqPdI7ecm1N33EzAetWahvQWVqLZtaZQ+IDKX4IyA2o0gBzqIMkAagHQ== | ||
|
@@ -17110,19 +17133,29 @@ tinyqueue@^2.0.3: | |
resolved "https://registry.yarnpkg.com/tinyqueue/-/tinyqueue-2.0.3.tgz#64d8492ebf39e7801d7bd34062e29b45b2035f08" | ||
integrity sha512-ppJZNDuKGgxzkHihX8v9v9G5f+18gzaTfrukGrq6ueg0lmH4nqVnA2IPG0AEH3jKEk2GRJCUhDoqpoiw3PHLBA== | ||
|
||
tldts-core@^6.1.71: | ||
version "6.1.71" | ||
resolved "https://registry.yarnpkg.com/tldts-core/-/tldts-core-6.1.71.tgz#04069cbdcf75b7fcb68fb4c1e00591cd3a2d4a5c" | ||
integrity sha512-LRbChn2YRpic1KxY+ldL1pGXN/oVvKfCVufwfVzEQdFYNo39uF7AJa/WXdo+gYO7PTvdfkCPCed6Hkvz/kR7jg== | ||
|
||
tldts@^6.1.32: | ||
version "6.1.71" | ||
resolved "https://registry.yarnpkg.com/tldts/-/tldts-6.1.71.tgz#e0db0853dd533628729d6a97a211450205fa21e4" | ||
integrity sha512-LQIHmHnuzfZgZWAf2HzL83TIIrD8NhhI0DVxqo9/FdOd4ilec+NTNZOlDZf7EwrTNoutccbsHjvWHYXLAtvxjw== | ||
dependencies: | ||
tldts-core "^6.1.71" | ||
|
||
tmp@^0.0.33: | ||
version "0.0.33" | ||
resolved "https://registry.yarnpkg.com/tmp/-/tmp-0.0.33.tgz#6d34335889768d21b2bcda0aa277ced3b1bfadf9" | ||
integrity sha512-jRCJlojKnZ3addtTOjdIqoRuPEKBvNXcGYqzO6zWZX8KfKEpnGY5jfggJQ3EjKuu8D4bJRr0y+cYJFmYbImXGw== | ||
dependencies: | ||
os-tmpdir "~1.0.2" | ||
|
||
tmp@~0.2.1: | ||
version "0.2.1" | ||
resolved "https://registry.yarnpkg.com/tmp/-/tmp-0.2.1.tgz#8457fc3037dcf4719c251367a1af6500ee1ccf14" | ||
integrity sha512-76SUhtfqR2Ijn+xllcI5P1oyannHNHByD80W1q447gU3mp9G9PSpGdWmjUOHRDPiHYacIk66W7ubDTuPF3BEtQ== | ||
dependencies: | ||
rimraf "^3.0.0" | ||
tmp@~0.2.3: | ||
version "0.2.3" | ||
resolved "https://registry.yarnpkg.com/tmp/-/tmp-0.2.3.tgz#eb783cc22bc1e8bebd0671476d46ea4eb32a79ae" | ||
integrity sha512-nZD7m9iCPC5g0pYmcaxogYKggSfLsdxl8of3Q/oIbqCqLLIO9IAF0GWjX1z9NZRHPiXv8Wex4yDCaZsgEw0Y8w== | ||
|
||
[email protected]: | ||
version "1.0.5" | ||
|
@@ -17201,6 +17234,13 @@ tough-cookie@^4.0.0: | |
universalify "^0.2.0" | ||
url-parse "^1.5.3" | ||
|
||
tough-cookie@^5.0.0: | ||
version "5.1.0" | ||
resolved "https://registry.yarnpkg.com/tough-cookie/-/tough-cookie-5.1.0.tgz#0667b0f2fbb5901fe6f226c3e0b710a9a4292f87" | ||
integrity sha512-rvZUv+7MoBYTiDmFPBrhL7Ujx9Sk+q9wwm22x8c8T5IJaR+Wsyc7TNxbVxo84kZoRJZZMazowFLqpankBEQrGg== | ||
dependencies: | ||
tldts "^6.1.32" | ||
|
||
tough-cookie@~2.5.0: | ||
version "2.5.0" | ||
resolved "https://registry.yarnpkg.com/tough-cookie/-/tough-cookie-2.5.0.tgz#cd9fb2a0aa1d5a12b473bd9fb96fa3dcff65ade2" | ||
|
@@ -17233,6 +17273,11 @@ [email protected]: | |
resolved "https://registry.yarnpkg.com/traverse/-/traverse-0.6.8.tgz#5e5e0c41878b57e4b73ad2f3d1e36a715ea4ab15" | ||
integrity sha512-aXJDbk6SnumuaZSANd21XAo15ucCDE38H4fkqiGsc3MhCK+wOlZvLP9cB/TvpHT0mOyWgC4Z8EwRlzqYSUzdsA== | ||
|
||
[email protected]: | ||
version "1.2.2" | ||
resolved "https://registry.yarnpkg.com/tree-kill/-/tree-kill-1.2.2.tgz#4ca09a9092c88b73a7cdc5e8a01b507b0790a0cc" | ||
integrity sha512-L0Orpi8qGpRG//Nd+H90vFB+3iHnue1zSSGmNOOCh1GLJ7rUKVwV2HvijphGQS2UmhUZewS9VgvxYIdgr+fG1A== | ||
|
||
treeverse@^2.0.0: | ||
version "2.0.0" | ||
resolved "https://registry.yarnpkg.com/treeverse/-/treeverse-2.0.0.tgz#036dcef04bc3fd79a9b79a68d4da03e882d8a9ca" | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will
isFullscreen
always be true? I guess that means that the windowresize
event only triggers when entering FS, and not leaving FS?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, line 78 is not calling the function with the correct params. Since it is calling the component's own
onFullscreenChange
(not the one in util/map), then `isFullscreen is always false since the functions args don't match up.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not entirely sure how this is working, but I think what you want is:
this.onFullscreenChange({ isFullscreen: false })
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First thing is, you are right, it should have been:
this.onFullscreenChange({ isFullscreen: false })
And I investigated a little more!
Above is the button triggering the
fullscreenchange
event. The propisFullscreen
istrue
when you switch to fullscreen andfalse
when you go back to normal mode.I believe the button is hidden in all scenario where map is used in plugin, so the event listener defined below never gets triggered:
maps-app/src/components/map/Map.js
Lines 74 to 82 in b781ff3
Next place
onFullscreenChange
is used is here:maps-app/src/components/map/Map.js
Lines 125 to 136 in b781ff3
The thing is,
isFullscreen
property is set tofalse
for plugins and never changes, so it is never used either:maps-app/src/components/plugin/Map.js
Lines 126 to 135 in b781ff3
It looks like I can try to clean things up a little, and if
resizeCount
gets updated properly, I may be able to useonFullscreenChange
incomponentDidUpdate
instead of adding the event listener. Let's see tomorrow.