fix(ux): implement ux improvements #22
Conversation
|
🚀 Deployed on https://pr-22.route-manager.netlify.dhis2.org |
kabaros
force-pushed
the
ux-review-fixes
branch
from
7bd4d5e to
0ac79e1
Compare
kabaros
force-pushed
the
ux-review-fixes
branch
from
157bc56 to
8dc1bfd
Compare
kabaros
force-pushed
the
ux-review-fixes
branch
from
8dc1bfd to
c301cc7
Compare
kabaros
changed the title
| toggleRoute(route, !enabled) | ||
| } | ||
| checked={!route.disabled} | ||
| label={i18n.t('Enable route')} |
There was a problem hiding this comment.
Should this be an inline label in the row or would it be better as a column header?
There was a problem hiding this comment.
@cooper-joe I will leave the Switch label as it is now, but let me know if you think moving it to a column header is better as Austin mentions (it does seem a bit crowded now)
There was a problem hiding this comment.
Agreed, I think we should move the Enable route label into the column heading.
| </ButtonStrip> | ||
| </ModalActions> | ||
| <ModalContent> | ||
| <div className={classes.formContainer}> | ||
| <InputField | ||
| required |
There was a problem hiding this comment.
I don't think code is required? I might be wrong though...
There was a problem hiding this comment.
yeah it seems to be required
kabaros
force-pushed
the
ux-review-fixes
branch
from
c301cc7 to
ad47a03
Compare
|
🎉 This PR is included in version 100.3.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This addresses few UX issues reported in the bugathon: