refactor: command palette navigation #1661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use native dialog element for modal container - separate modal logic to a useModal hook - add a constants file for commonly used strings
|
🚀 Deployed on https://pr-1661--dhis2-ui.netlify.app |
d-rita
force-pushed
the
refactor/modal-navigation
branch
from
ff61e51 to
d3114bb
Compare
d-rita
force-pushed
the
refactor/modal-navigation
branch
from
584ed09 to
e2c13cd
Compare
- remove functionality creating focus on 2 items at once by keyboard and hovering - update test simulating focus by hovering over an item
d-rita
changed the title
- add key press handlers for each arrow key
- add test to search for logout on home view - add filterable_action type - add actions to all items that can be filtered via the useFilter hook - remove setup for commands
This was referenced Feb 14, 2025
* feat: update esc, tab and backspace keydown logic * feat: override default behaviour for cmd+k shortcut * fix: input component import * fix: open apps in same window
d-rita
changed the base branch from
DHIS2-18943/fix-apps-menu-redirect
to
feature-command-palette
3 tasks
amcgee
approved these changes
Feb 19, 2025
components/header-bar/src/command-palette/__tests__/browse-apps-view.test.js
Outdated
Show resolved
Hide resolved
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves upon the implementation of the command palette navigation.
useNavigationhook into separate functionsIt also adds a criterion for searchable actions, including logout.
Related PRs:
NB: The issues solved in these PRs are also fixed here with this update.
Checklist