Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(command-palette): selectable back action #1668

Merged
merged 3 commits into from
Feb 24, 2025

Conversation

d-rita
Copy link
Contributor

@d-rita d-rita commented Feb 17, 2025

Implements LIBS-753


Description

This PR avails the back action as a list item on the "All Items" list views, i.e. Browse Apps, Browse Shortcuts, Browse Commands, hence making it selectable for the user via keyboard.


Checklist

  • API docs are generated
  • Tests were added
  • Storybook demos were added

Screenshots

  1. Back Action
back.mov
  1. Remove headings from All List views and Search Results
no.headings.mov

@d-rita d-rita requested review from cooper-joe and a team February 17, 2025 14:21
@d-rita d-rita requested a review from a team as a code owner February 17, 2025 14:21
@dhis2-bot
Copy link
Contributor

dhis2-bot commented Feb 17, 2025

🚀 Deployed on https://pr-1668--dhis2-ui.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify February 17, 2025 14:26 Inactive
Copy link
Member

@amcgee amcgee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

Base automatically changed from refactor/modal-navigation to feature-command-palette February 24, 2025 15:12
- remove headings from list views
- use ListView component to display already filtered items per current view
- add a back to home action to available actions
- update list navigation to account for the presence of the backActionItem
@d-rita d-rita force-pushed the LIBS-753/selectable-back-action branch from 3762e33 to de53c30 Compare February 24, 2025 18:11
@dhis2-bot dhis2-bot temporarily deployed to netlify February 24, 2025 18:16 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify February 24, 2025 18:23 Inactive
@d-rita d-rita merged commit 44b6701 into feature-command-palette Feb 24, 2025
18 checks passed
@d-rita d-rita deleted the LIBS-753/selectable-back-action branch February 24, 2025 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants