Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(headerbar): profile menu design changes #1670

Open
wants to merge 2 commits into
base: feature-command-palette
Choose a base branch
from

Conversation

cooper-joe
Copy link
Member

@cooper-joe cooper-joe commented Feb 20, 2025

Implements UX-113


Description

This PR updates the design of the profile menu in HeaderBar. The following changes are made:

  • Adjust menu item labels, icons. The remapping of menu items are detailed in the linked ticket.
  • 'My Profile' menu item replaces the 'Edit profile' link
  • Custom items (debug info, app update notification) use button instead of MenuItem
  • Display username instead of email in ProfileHeader.

Questions:

  • Do these changes warrant a breaking change with the removal of the email prop from many components? I wasn't sure, as these components are not intended for consumption outside of the main profile menu component.
  • The content tests (e.g. checking for the right username) are based on a mock response, should these be changed to check a real response?

Checklist

  • API docs are generated
  • Tests were added
  • Storybook demos were added

All points above should be relevant for feature PRs. For bugfixes, some points might not be relevant. In that case, just check them anyway to signal the work is done.


Screenshots

image

image

SCR-20250220-c1v

@cooper-joe cooper-joe requested a review from a team as a code owner February 20, 2025 11:55
@cooper-joe cooper-joe requested a review from a team February 20, 2025 11:56
@amcgee amcgee changed the base branch from beta to feature-command-palette February 26, 2025 14:27
@amcgee amcgee force-pushed the profile-menu-beta-base branch from 1a226d7 to 9f51f11 Compare February 26, 2025 14:39
@amcgee
Copy link
Member

amcgee commented Feb 26, 2025

Force-pushed this to rebase it onto the command palette branch, which will be ported to the global shell repo

@dhis2-bot
Copy link
Contributor

dhis2-bot commented Feb 26, 2025

🚀 Deployed on https://pr-1670--dhis2-ui.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify February 26, 2025 14:43 Inactive
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
2 New issues
2 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@dhis2-bot dhis2-bot temporarily deployed to netlify February 28, 2025 12:31 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants