-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add send email verification button #1445
Conversation
🚀 Deployed on https://pr-1445--dhis2-user-profile.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 😄!
I left a couple of suggestions / questions. In terms of functionality, I think just fixing the emailConfigured and the conditional display of the "Verify email" button (i.e. hide the button when email is not configured) are necessary to satisfy the ticket requirements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 🚀
Do you want to remove the handleEmailVerification
from src/layout/FormFields.component.js as it is not used?
🎉 This PR is included in version 100.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Implements DHIS2-18374
Description
This PR introduces functionality to allow users to initialize the email verification process from their profile page. It adheres to the outlined acceptance criteria and integrates backend communication to handle email verification requests.
Checklist