Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use password regex [DHIS2-15704] #1469

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

tomzemp
Copy link
Member

@tomzemp tomzemp commented Jan 9, 2025

Background

See the ticket DHIS2-15704 for description of changes by version

Code

The AccountEditor component has some direct logic checks to use create a RegEx from minPasswordLength + maxPasswordLength from api/systemSettings.

Testing

  • There are no automated tests for this app, so I am not spending the time to add them here, though there really should be testing for functionality as core as reseting your password 😢.
  • I've manually tested. Note for manual testing, you can change the minPasswordLength in Settings App (access page), whereas maxPasswordLength must be set via the api.

@dhis2-bot
Copy link
Contributor

dhis2-bot commented Jan 9, 2025

🚀 Deployed on https://pr-1469--dhis2-user-profile.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify January 9, 2025 12:31 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify January 23, 2025 12:51 Inactive
@tomzemp tomzemp marked this pull request as ready for review January 23, 2025 13:41
@tomzemp tomzemp requested a review from a team January 23, 2025 13:42
@tomzemp tomzemp marked this pull request as draft January 23, 2025 14:08
@tomzemp tomzemp marked this pull request as ready for review January 30, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants